Match hashlib constructor name type diagnostics by youknowdot · Pull Request #9066 · RustPython/RustPython

youknowdot · 2026-10-10T12:39:24Z

Current Python 3.15 main target

#8950 is merged. This PR now targets main and replays only its unique commits onto 06007c81fa99e813cbf4583dab326764ba0ef017. Current head: 4c8093dec7d9366dad4a81fe1abb77f41d621e06. The prior bootstrap commits are not part of this PR's diff.

Normal commit hooks, whitespace checks, and independent source/patch-equivalence review passed. The intervening main fixes are preserved and this PR introduces no changes under Lib/. No new local build or runtime validation is claimed for this rebased head. The maintainer-requested [skip ci] marker remains; full CI is intentionally paused pending selective validation.

Prior stack and validation history

The base/head references below describe earlier revisions; the current target and validation limits above supersede them.

Temporary CI pause

The head commit includes [skip ci] at the maintainer's request. This message-only amendment preserves the exact source tree and commit parents. Normal pull-request CI is intentionally skipped; required checks may remain pending. This does not itself cancel older runs or suppress pull_request_target workflows.

Python 3.15 stack

Depends on #8950 at 80d3e52f32341d3158c659d82a927373b51b6439. This PR targets the upstream stack/python-3.15-8950 branch at that exact commit, so its displayed diff contains only the leaf changes. Unique changes above #8950.

Current head e4f86457f3ae15def3a3d7b32cece1b73597b215 was checked by source/range-diff review, normal commit hooks, and patch checks. Its unique delta changes no files under Lib/ and inherits the 3.15.0 reference. No new local build or runtime execution is claimed for this stacked head; validation described below applies to the earlier head unless explicitly updated. Exact-head hosted CI is temporarily skipped.

Summary

Extract the Python 3.14-compatible _hashlib.new name-type diagnostic from #8954, correcting the mega implementation's formatting details.

For non-string names, report new() argument 'name' must be str, not TYPE. Match CPython's special spelling for None, stored native type name, and 50-byte UTF-8 precision without splitting a code point. Actual strings retain the existing PyUtf8StrRef conversion. Algorithm selection, hashing, and usedforsecurity behavior are unchanged; the separate 3.15 string= deprecation warning is excluded.

Sources: 3.14.7 generated parser, 3.14.8 bad-argument diagnostic, and UTF-8 precision handling.

Add six focused cases to the existing hashlib Python snippet, covering None, ordinary builtins, a qualified native type, and ASCII/non-ASCII truncation. No canonical assertions or unrelated diagnostic helpers change.

Validation

Independent source/ownership review, normal hooks, and native debug build passed.
Exact CPython 3.14.7/3.14.8 and native bounded checks agree on 12 type-name diagnostics and an accepted string subclass, including nested/renamed types, blocked Python metadata lookup, and UTF-8 boundaries. The baseline fails the new diagnostic regression.
The complete hashlib snippet and both snippet pytest entries pass using the pinned 3.14.7 reference.
Four unchanged canonical hashlib tests pass: unknown hashes, uppercase name normalization, name attributes, and Unicode-data rejection.
Stdlib and separately configured CAPI Clippy pass with -D warnings.

All behavior assertions are Python tests. Embedded-NUL handling and broader argument-binding diagnostic precedence are separate pre-existing contracts, not claims of this change. hosted CI is temporarily skipped.

Summary by CodeRabbit

New Features
- RustPython now targets Python 3.15.
- Sequence repetition for strings, bytes, and tuples is supported in both operand orders, including in-place multiplication.
Bug Fixes
- _hashlib.new() now raises a TypeError for non-string algorithm names and identifies the supplied value’s type. Long type names are limited to 50 characters without splitting a UTF-8 character.
- Improved compatibility for logarithms of large integer-like values, Windows timestamps, CSV dialect errors, struct formats, and other Python 3.15 behaviors.
- Formatting errors now identify the argument and conversion specifier.

coderabbitai · 2026-10-10T12:39:33Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
Review profile: CHILL
Plan: Advanced
Run ID: 137fce10-0db7-4173-9f73-8aca72d8838f

📥 Commits

Reviewing files that changed from the base of the PR and between 4a41ab5 and 586fc7d.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
Review profile: CHILL
Plan: Advanced
Run ID: 84bdd49c-e5bf-46a8-b8e1-f962ccf3bd14

📥 Commits

Reviewing files that changed from the base of the PR and between b63c3b0 and c2a9d84.

📒 Files selected for processing (2)

crates/stdlib/src/hashlib.rs
extra_tests/snippets/stdlib_hashlib.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

Walkthrough

_hashlib.new() now rejects non-string algorithm names with a TypeError that identifies the input type. Valid string names continue through the existing algorithm lookup.

Changes

Hashlib Name Validation

Layer / File(s)	Summary
Validate and process algorithm names `crates/stdlib/src/hashlib.rs`, `extra_tests/snippets/stdlib_hashlib.py`	`HashName` validates algorithm-name inputs and provides the string for lookup. Tests cover several non-string inputs and type names longer than 50 characters.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: youknowone

Merge Risk: ⚪ Minimal · up to c2a9d

No identified issue blocks merging after normal checks.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the primary change: aligning hashlib constructor name type diagnostics with the reference behavior.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector · 2026-10-10T12:58:13Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-11T16:12:09.092489Z	`586fc7d`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2a9d84ecf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-10T13:04:22Z

        dict.into()
    }

+    #[derive(Debug)]


Add the required AI-assistance trailer

This commit is authored by Codex <codex@openai.com>, but the reviewed commit message has no Assisted-by: trailer. Repository policy requires that exact trailer form for every AI-assisted contribution, so add it before this commit is merged.

AGENTS.md reference: AGENTS.md:L23-L23

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-10T13:04:22Z

+):
+    with assert_raises(TypeError) as caught:
+        _hashlib.new(value)
+    assert str(caught.exception) == f"new() argument 'name' must be str, not {name}"


Remove the prohibited test assertion

This appended loop introduces new test data, test logic, and an assertion in an existing test file. Repository policy explicitly forbids modifying test assertions, logic, or data, so remove this test hunk before merging.

AGENTS.md reference: AGENTS.md:L275-L275

Useful? React with 👍 / 👎.

codspeed · 2026-10-10T16:02:41Z

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks¹

_{Comparing youknowdot:fix-hashlib-name-diagnostic (c2a9d84) with main (b63c3b0)}

4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

chatgpt-codex-connector · 2026-10-11T03:14:51Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

chatgpt-codex-connector · 2026-10-11T03:21:46Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

github-actions · 2026-10-11T05:33:19Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_mmap.py (TODO: 19)

dependencies:

dependent tests: (2 tests)

mmap: test_os
- multiprocessing.shared_memory: test_genericalias

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

Use native type names, None spelling, and UTF-8 byte precision for invalid name arguments without changing accepted strings or hashing behavior. Assisted-by: OpenAI Codex:model identifier unavailable

youknowone approved these changes Oct 10, 2026

View reviewed changes

youknowone marked this pull request as ready for review October 10, 2026 12:58

youknowone enabled auto-merge (squash) October 10, 2026 12:58

chatgpt-codex-connector Bot reviewed Oct 10, 2026

View reviewed changes

auto-merge was automatically disabled October 11, 2026 03:14
Head branch was pushed to by a user without write access

youknowdot force-pushed the fix-hashlib-name-diagnostic branch from c2a9d84 to d7ddade Compare October 11, 2026 03:14

youknowdot force-pushed the fix-hashlib-name-diagnostic branch from d7ddade to e4f8645 Compare October 11, 2026 03:21

youknowone changed the base branch from main to stack/python-3.15-8950 October 11, 2026 03:25

youknowdot force-pushed the fix-hashlib-name-diagnostic branch from e4f8645 to 4c8093d Compare October 11, 2026 04:07

youknowone changed the base branch from stack/python-3.15-8950 to main October 11, 2026 04:09

youknowdot force-pushed the fix-hashlib-name-diagnostic branch from 4c8093d to 4a41ab5 Compare October 11, 2026 04:14

Match hashlib constructor name type diagnostics

586fc7d

Use native type names, None spelling, and UTF-8 byte precision for invalid name arguments without changing accepted strings or hashing behavior. Assisted-by: OpenAI Codex:model identifier unavailable

youknowdot force-pushed the fix-hashlib-name-diagnostic branch from 4a41ab5 to 586fc7d Compare October 11, 2026 16:08

youknowone merged commit 924ef2f into RustPython:main Oct 11, 2026
20 checks passed

Navigation Menu

Repository navigation

Match hashlib constructor name type diagnostics - #9066

Match hashlib constructor name type diagnostics#9066
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix-hashlib-name-diagnostic

youknowdot commented Oct 10, 2026 •

edited by youknowone

Loading

Uh oh!

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

chatgpt-codex-connector Bot commented Oct 10, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 10, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 10, 2026

Uh oh!

codspeed Bot commented Oct 10, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 11, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 11, 2026

Uh oh!

github-actions Bot commented Oct 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

youknowdot commented Oct 10, 2026 • edited by youknowone Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Python 3.15 main target

Prior stack and validation history

Temporary CI pause

Python 3.15 stack

Summary

Validation

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

chatgpt-codex-connector Bot commented Oct 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 10, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 10, 2026

Choose a reason for hiding this comment

Uh oh!

codspeed Bot commented Oct 10, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

chatgpt-codex-connector Bot commented Oct 11, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 11, 2026

Uh oh!

github-actions Bot commented Oct 11, 2026

📦 Library Dependencies

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

youknowdot commented Oct 10, 2026 •

edited by youknowone

Loading

coderabbitai Bot commented Oct 10, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 10, 2026 •

edited

Loading