Repository navigation
Drop the legacy abi3-only PyCFunction_Call export - #9059
Merged
youknowone merged 1 commit intoOct 10, 2026
Merged
Conversation
Follow up on RustPython#9055: RustPython targets abi3t, which does not require this legacy binary-compatibility entry point. Assisted-by: OpenAI Codex:model identifier unavailable
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bschoenmaeckers
approved these changes
Oct 10, 2026
youknowone
approved these changes
Oct 10, 2026
youknowone
marked this pull request as ready for review
October 10, 2026 11:57
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove only the ten lines added by #9055, following the ABI-scope review: #9055 (review).
RustPython targets
RustPython-abi3t-3.15, with free-threaded ABI configuration.PyCFunction_Callis a legacy ABI-only symbol, absent from the supported public header surface for this target. The local fixture for #9055 established call behavior, but did not establish that RustPython needed this export. That distinction was missed in the original extraction.This is an exact inverse of #9055's production change, with no other C API changes.
PyCFunction_NewandPyObject_Callremain exported. CPython still physically exports the legacy symbol; this change concerns RustPython's supported ABI surface, rather than claiming the symbol cannot be called anywhere.Sources:
Validation
cargo build --locked --offline --features capi -j1 --bin rustpythonpassed.PyCFunction_Callabsent andPyCFunction_New/PyObject_Callpresent.crates/capi:cargo clippy --offline --tests -j1 -- -D warningspassed.The full workspace test suite was not run locally; hosted CI will supply broader coverage. No Python behavior or test assertions change.