Skip to content

CI: bound dependency comments and retain complete reports - #8958

Draft
youknowdot wants to merge 1 commit into
RustPython:mainfrom
youknowdot:fix-lib-deps-comment-size
Draft

youknowdot wants to merge 1 commit into
RustPython:mainfrom
youknowdot:fix-lib-deps-comment-size

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Current revision

Targets Python 3.15 main at f39da82d9d38cd5bdceb9e645205e830f65126fb with one logical commit, 8ec23f5c7127c32da0f31b04ca8aebacdddc1bec. The unique patch is unchanged from the prior reviewed PR head (range-diff =); current main fixes, original author attribution, and assistance trailers are preserved. No files under Lib/ are changed.

Normal commit hooks, changed-range hooks, whitespace checks, and source-equivalence review passed. Normal hosted CI is enabled for this exact head. No new native build or runtime validation is claimed; earlier results below remain attributed to their original revisions.

The workflow uses the trusted base revision, so this change becomes effective for library PRs after it lands on main. Hosted lint is the current zizmor gate; no local zizmor result is claimed.

Large standard-library updates generate a dependency report that is too large for the comment action's environment input. On #8954, the 157,859-byte report prevents Node from starting with Argument list too long.

Write the report to a temporary file and pass its path to the existing pinned comment action. Short reports remain in the comment; longer reports link to the complete run summary. Reports above the summary's 1 MiB limit use an artifact with the repository's existing pinned upload action.

The workflow correction itself is independent of the Python version; this branch now shares the Python 3.15 base requested for the stack. The trigger, token permissions, checkout/trust boundary, existing action versions and no-Lib-change removal behavior are retained. Because this is a pull_request_target workflow, the correction must reach the trusted base branch before dependent PRs can use it.

Validation:

  • Exact inline workflow code passes empty, small, 160 KB Unicode, recorded-failure and comment/summary boundary fixtures
  • Report-capture shell preserves tolerated command failures and treats report text as data
  • YAML parsing, patch checks and normal configured commit hooks pass
  • Zizmor 1.30.1 reports the same inherited high-severity dangerous-triggers finding on unchanged main and this change, with no new findings. This is not a clean local scan; no suppression or trigger/permission change was added
  • No live comment/artifact posting or new workflow execution has been claimed

The existing failed run supplies the current failure evidence. Main CI approval is a separate issue.

AI assistance: prepared and validated with Codex at the user's direction. Exact model metadata is unavailable; the commit records Assisted-by: Codex:model-version-unavailable.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@youknowdot
youknowdot force-pushed the fix-lib-deps-comment-size branch 2 times, most recently from b067caa to 03dcc7c Compare October 11, 2026 03:21
@youknowone
youknowone changed the base branch from main to stack/python-3.15-8950 October 11, 2026 03:24
@youknowdot
youknowdot force-pushed the fix-lib-deps-comment-size branch from 03dcc7c to dec4547 Compare October 11, 2026 04:07
@youknowone
youknowone changed the base branch from stack/python-3.15-8950 to main October 11, 2026 04:07
@youknowdot
youknowdot force-pushed the fix-lib-deps-comment-size branch from dec4547 to 89d0779 Compare October 11, 2026 04:14
@github-actions

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_mmap.py (TODO: 19)

dependencies:

dependent tests: (2 tests)

  • mmap: test_os
    • multiprocessing.shared_memory: test_genericalias

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

Pass dependency reports through files, retain short reports in comments, and preserve complete longer reports in summaries or artifacts. Keep existing triggers, permissions, action pins, and trust boundaries.

Assisted-by: Codex:model-version-unavailable
@youknowdot
youknowdot force-pushed the fix-lib-deps-comment-size branch from 89d0779 to 8ec23f5 Compare October 11, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant