Stream deque inputs and release evicted items outside locks - #8860

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

Deque append and extension operations now share helpers for insertion, mutation tracking, and maxlen trimming. Extension handles self-extension, bounded containers, and other iterables through distinct paths. New tests cover partial updates on errors, iterator behavior, and object lifetime.

Changes

Deque mutation and extension

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: youknowone

Security Blast Radius

• inferred — The directly established exposure is callers of the VM deque API and objects they supply. The available evidence does not establish tenant, service, data-store, or deployment-level exposure.

Trust Boundaries and Controls

• inferred — Moving object release outside the lock changes when existing caller-controlled finalizers can reenter the deque; it does not, on the inspected path, grant those objects a new privilege.

Resilience and Maintainability Implications

• inferred — The concurrent generation-check window can weaken fail-fast iteration, but its use in an authorization or other security-sensitive decision was not established.

Hardening Proposals

• proposed — If concurrent deque access is supported, validate mutation generation together with the locked deque read and exercise the writer-held-lock interleaving in a concurrency test.

❌ Failed checks (1 warning)

• X
• Mastodon
• Reddit
• LinkedIn