Fix struct complex conversion and overflow behavior by doma17 · Pull Request #8829 · RustPython/RustPython

doma17 · 2026-09-26T04:55:44Z

Closes struct: Python 3.14 complex formats F and D are unsupported #8800
This PR follows our AI policy

Summary

Follow up on the struct F/D support added in #8780 to match CPython's
conversion and overflow behavior:

Use the stored value of complex subclasses without calling their __complex__.
Do not warn when __complex__ returns an exact complex.
Raise OverflowError for overflowing F components with opposite byte order,
while preserving CPython's matching-endian casts.

Reuse the existing format types and unpacking implementation. Add regression
coverage for these cases.

AI assistance: Codex assisted with implementation, tests, review, and this description.

Testing

test_struct, test_memoryview, test_complex, and test_cmath
Compared format, conversion, and overflow behavior with CPython 3.14.7
Workspace and separate C-API tests and Clippy
pytest -v: 472 passed with sqlite enabled
prek run --all-files

Summary by CodeRabbit

New Features
- struct.pack supports the "F" and "D" format codes for complex values, including objects converted through __complex__.
Bug Fixes
- Complex subclasses can be packed using their stored value without calling an overridden __complex__ method.
- Packing large values with "F" in opposite-endian byte order raises OverflowError.
- Conversion warnings are limited to cases where __complex__ returns a strict subclass of complex.

Accept F/D through the existing buffer packing implementation and restore its complex round-trip test. Fix exact __complex__ results warning as subclasses so valid conversions also work with warnings treated as errors. Codex assisted with implementation, regression coverage, and review. Tested: CPython 3.14.7 comparison; struct/memoryview/complex/cmath; workspace and C-API tests; Clippy; pytest; prek Assisted-by: Codex:gpt-6-astra

chatgpt-codex-connector · 2026-09-26T04:55:50Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

coderabbitai · 2026-09-26T04:56:10Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: eaca6adc-df71-49f1-9562-7d747e082a16

📥 Commits

Reviewing files that changed from the base of the PR and between f6550c4 and acc3605.

📒 Files selected for processing (1)

crates/vm/src/buffer.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Complex packing now reads existing PyComplex values directly and converts other inputs. It reports overflow when narrowing finite components for non-native byte order. The __complex__ deprecation warning applies to strict subclasses, not exact complex results. Tests cover conversion and overflow behavior.

Changes

Complex struct formats

Layer / File(s)	Summary
Complex conversion behavior `crates/vm/src/builtins/complex.rs`, `extra_tests/snippets/stdlib_struct_complex.py`	`try_complex` emits the deprecation warning for strict subclasses of `complex`, but not exact `complex` results. Tests cover objects converted through `__complex__` and complex subclasses.
Complex format packing `crates/vm/src/buffer.rs`, `extra_tests/snippets/stdlib_struct_complex.py`	Packing reads `PyComplex` values directly and converts other inputs. For non-native byte order, it reports overflow when narrowing a finite component produces infinity. Tests cover `"F"` and `"D"` conversion and `"F"` overflow behavior.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Feature

Suggested reviewers: youknowone

Merge Risk: ⚪ Minimal · up to acc36

The supplied evidence identifies no issue that needs resolution before merge; complete the normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to acc36

The change affects 2 systems.

Changed systems: crates, extra_tests

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — crates (service) was modified; 2 changed files map to changed impact.
observed — extra_tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in crates/vm/src/builtins/complex.rs: The __complex__ result check now requires the returned object to downcast to PyComplex and its class not to be the exact built-in complex type before entering the deprecation-warning branch. Previously, any PyComplex result entered that branch.
observed — Modified behavior in extra_tests/snippets/stdlib_struct_complex.py: Adds checks for complex conversion in struct.pack under warnings-as-errors for "F" and "D": a non-complex object is converted through __complex__, while a complex subclass uses its stored value despite an override that raises. It also checks that native-endian "F" packing matches "@f" for large real or imaginary values, and that opposite-endian packing raises OverflowError.
observed — Modified behavior in crates/vm/src/buffer.rs: Imports PyComplex for direct complex-object handling in the packer.
observed — Modified behavior in crates/vm/src/buffer.rs: Complex packing now reads PyComplex directly, using ArgIntoComplex for other inputs. It narrows and packs real and imaginary components separately, reporting a Value-kind overflow when a finite component becomes infinite for non-native byte order; the error names the target f or d format.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Issue `#8800` requires `struct` support for `F` and `D` complex formats during packing and unpacking. The reviewed changes add complex packing through existing `PyComplex` values and `ArgIntoComplex` co…
Out of Scope Changes check	✅ Passed	The `__complex__` warning change directly supports the required `struct.pack` conversion path. The added conversion and overflow tests verify that behavior. The reviewed changes show no demonstrated u…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main changes: complex conversion fixes and overflow behavior in struct packing.

Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-26T04:56:41Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[ ] test: cpython/Lib/test/test_unicodedata.py (TODO: 25)
[x] test: cpython/Lib/test/test_unicode_file.py
[x] test: cpython/Lib/test/test_unicode_file_functions.py
[x] test: cpython/Lib/test/test_unicode_identifiers.py (TODO: 1)
[x] test: cpython/Lib/test/test_ucn.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on unicode)

[x] test: cpython/Lib/test/test_itertools.py (TODO: 3)

dependencies:

dependent tests: (56 tests)

itertools: test_annotationlib test_ast test_asyncio test_bdb test_buffer test_builtin test_call test_codeccallbacks test_collections test_compile test_concurrent_futures test_csv test_ctypes test_descr test_dis test_email test_exceptions test_functools test_genericalias test_hashlib test_heapq test_httplib test_importlib test_inspect test_io test_iterlen test_itertools test_launcher test_logging test_math test_memoryview test_mmap test_os test_peepholer test_platform test_pprint test_pyrepl test_queue test_range test_set test_shlex test_slice test_socket test_sort test_statistics test_str test_struct test_subprocess test_tokenize test_tuple test_typing test_unittest test_uuid test_winreg test_xml_etree test_zipfile

[x] lib: cpython/Lib/inspect.py
[ ] test: cpython/Lib/test/test_inspect (TODO: 17)

dependencies:

inspect

dependent tests: (97 tests)

[x] lib: cpython/Lib/warnings.py
[ ] lib: cpython/Lib/_py_warnings.py
[ ] test: cpython/Lib/test/test_warnings (TODO: 12)

dependencies:

warnings (native: _contextvars, _thread, _warnings, builtins, sys)
- _py_warnings
- _py_warnings (native: _contextvars, _thread, builtins, sys)
- functools, inspect, linecache, re, traceback, tracemalloc, types

dependent tests: (55 tests)

warnings: test_argparse test_array test_asyncio test_buffer test_builtin test_codecs test_codeop test_compile test_coroutines test_ctypes test_decimal test_descr test_fnmatch test_fstring test_funcattrs test_genericpath test_glob test_global test_grammar test_gzip test_hashlib test_hmac test_importlib test_inspect test_io test_logging test_ntpath test_os test_pickle test_posix test_pty test_pyclbr test_pyrepl test_random test_re test_runpy test_set test_socket test_sqlite3 test_str test_string_literals test_support test_sys test_sys_settrace test_tarfile test_tempfile test_thread test_threading test_type_cache test_typing test_unicode_file_functions test_unittest test_unparse test_xml_etree test_zipimport

[x] lib: cpython/Lib/threading.py
[x] lib: cpython/Lib/_threading_local.py
[ ] test: cpython/Lib/test/test_threading.py (TODO: 8)
[x] test: cpython/Lib/test/test_threadedtempfile.py
[x] test: cpython/Lib/test/test_threading_local.py

dependencies:

threading

dependent tests: (166 tests)

[x] lib: cpython/Lib/struct.py
[x] test: cpython/Lib/test/test_struct.py (TODO: 1)

dependencies:

struct

dependent tests: (179 tests)

[x] lib: cpython/Lib/pydoc.py
[x] lib: cpython/Lib/pydoc_data
[ ] test: cpython/Lib/test/test_pydoc (TODO: 24)

dependencies:

pydoc

dependent tests: (5 tests)

pydoc: test_enum test_pydoc
- pdb: test_pdb
- xmlrpc.server: test_docxmlrpc test_xmlrpc

[x] lib: cpython/Lib/doctest.py
[ ] test: cpython/Lib/test/test_doctest (TODO: 5)

dependencies:

doctest

dependent tests: (36 tests)

doctest: test_builtin test_cmd test_code test_collections test_ctypes test_decimal test_deque test_descrtut test_difflib test_doctest test_doctest2 test_enum test_extcall test_generators test_genexps test_getopt test_heapq test_http_cookies test_itertools test_listcomps test_math test_metaclass test_pdb test_pep646_syntax test_pickle test_pickletools test_setcomps test_statistics test_syntax test_threading_local test_typing test_unpack test_unpack_ex test_weakref test_zipimport test_zipimport_support

[x] test: cpython/Lib/test/test_builtin.py (TODO: 11)

dependencies:

dependent tests: (no tests depend on builtin)

[x] test: cpython/Lib/test/test_list.py (TODO: 1)
[x] test: cpython/Lib/test/test_listcomps.py
[ ] test: cpython/Lib/test/test_userlist.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on list)

[x] lib: cpython/Lib/trace.py
[x] test: cpython/Lib/test/test_trace.py (TODO: 6)

dependencies:

trace

dependent tests: (1 tests)

trace: test_trace

[x] lib: cpython/Lib/io.py
[x] lib: cpython/Lib/_pyio.py
[ ] test: cpython/Lib/test/test_io.py (TODO: 7)
[x] test: cpython/Lib/test/test_bufio.py
[x] test: cpython/Lib/test/test_fileio.py (TODO: 1)
[ ] test: cpython/Lib/test/test_memoryio.py (TODO: 3)

dependencies:

io

dependent tests: (108 tests)

io: test__colorize test_android test_argparse test_ast test_asyncio test_base64 test_buffer test_bufio test_builtin test_bz2 test_calendar test_cmd test_cmd_line_script test_codecs test_compile test_compileall test_compiler_assemble test_concurrent_futures test_configparser test_contextlib test_csv test_dbm_dumb test_descr test_dis test_email test_enum test_file test_fileinput test_fileio test_ftplib test_generated_cases test_getpass test_gzip test_hashlib test_http_cookiejar test_httplib test_httpservers test_importlib test_inspect test_io test_json test_largefile test_logging test_lzma test_mailbox test_marshal test_memoryio test_memoryview test_mimetypes test_minidom test_multibytecodec test_optparse test_pathlib test_pdb test_peg_generator test_pickle test_pickletools test_platform test_plistlib test_pprint test_print test_profile test_pstats test_pty test_pulldom test_pydoc test_pyexpat test_pyrepl test_quopri test_regrtest test_robotparser test_sax test_shlex test_shutil test_site test_smtplib test_socket test_socketserver test_subprocess test_support test_sys test_tarfile test_tempfile test_threadedtempfile test_timeit test_tokenize test_traceback test_types test_typing test_unittest test_univnewlines test_urllib test_urllib2 test_uuid test_wave test_webbrowser test_winconsoleio test_wsgiref test_xml_dom_xmlbuilder test_xml_etree test_xml_etree_c test_xmlrpc test_xpickle test_zipapp test_zipfile test_zipimport test_zoneinfo test_zstd

[x] lib: cpython/Lib/collections
[x] lib: cpython/Lib/_collections_abc.py
[x] test: cpython/Lib/test/test_collections.py
[x] test: cpython/Lib/test/test_deque.py (TODO: 2)
[x] test: cpython/Lib/test/test_defaultdict.py
[x] test: cpython/Lib/test/test_ordered_dict.py (TODO: 9)

dependencies:

collections

dependent tests: (332 tests)

[x] lib: cpython/Lib/abc.py
[x] lib: cpython/Lib/_py_abc.py
[x] test: cpython/Lib/test/test_abc.py (TODO: 1)

dependencies:

abc

dependent tests: (11 tests)

abc: test_abc test_abstract_numbers test_binop test_copy test_descr test_dynamicclassattribute test_functools test_inspect test_io test_pyexpat test_typing

[x] lib: cpython/Lib/re
[x] lib: cpython/Lib/sre_compile.py
[x] lib: cpython/Lib/sre_constants.py
[x] lib: cpython/Lib/sre_parse.py
[ ] test: cpython/Lib/test/test_re.py (TODO: 6)
[x] test: cpython/Lib/test/re_tests.py

dependencies:

re

dependent tests: (82 tests)

re: test_android test_ast test_asyncio test_binascii test_builtin test_bytes test_clinic test_cmd_line test_ctypes test_dict test_dis test_docxmlrpc test_dtrace test_email test_embed test_faulthandler test_filecmp test_fileinput test_fnmatch test_format test_frame test_fstring test_functools test_future_stmt test_generated_cases test_genericalias test_glob test_hashlib test_http_cookiejar test_httplib test_httpservers test_imaplib test_importlib test_inspect test_ipaddress test_launcher test_logging test_mailbox test_mmap test_optparse test_ordered_dict test_platform test_pprint test_pydoc test_pyexpat test_pyrepl test_re test_regrtest test_runpy test_set test_site test_smtplib test_socket test_ssl test_strftime test_string test_strptime test_strtod test_structseq test_symtable test_syntax test_sys test_sysconfig test_tarfile test_tempfile test_tokenize test_tools test_traceback test_turtle test_typing test_unittest test_unparse test_venv test_webbrowser test_winapi test_with test_wsgiref test_xmlrpc test_zipfile test_zipimport test_zoneinfo test_zstd

[ ] lib: cpython/Lib/zoneinfo
[ ] test: cpython/Lib/test/test_zoneinfo (TODO: 5)

dependencies:

zoneinfo (native: _common, _zoneinfo)
- pickle (native: _pickle, itertools, sys)
- sysconfig (native: _sysconfig, _winapi, importlib.machinery, importlib.util, os.path, sys)
- warnings
- bisect, calendar, collections, datetime, functools, importlib, os, re, struct, weakref

dependent tests: (2 tests)

zoneinfo: test_plistlib test_zoneinfo

[x] lib: cpython/Lib/rlcompleter.py
[x] test: cpython/Lib/test/test_rlcompleter.py (TODO: 1)

dependencies:

rlcompleter

dependent tests: (4 tests)

rlcompleter: test_pyrepl test_rlcompleter
- pdb: test_pdb
- site: test_site

[ ] test: cpython/Lib/test/test_sys.py (TODO: 7)
[x] test: cpython/Lib/test/test_syslog.py
[x] test: cpython/Lib/test/test_sys_setprofile.py (TODO: 1)
[ ] test: cpython/Lib/test/test_sys_settrace.py
[x] test: cpython/Lib/test/test_audit.py (TODO: 14)
[x] test: cpython/Lib/test/audit-tests.py

dependencies:

dependent tests: (239 tests)

sys: regrtestdata test___all__ test__colorize test__locale test__osx_support test_android test_annotationlib test_argparse test_array test_asdl_parser test_ast test_asyncio test_audit test_bdb test_bigaddrspace test_bigmem test_bisect test_buffer test_builtin test_bytes test_bz2 test_c_locale_coercion test_calendar test_class test_clinic test_cmath test_cmd test_cmd_line test_cmd_line_script test_code test_code_module test_codeccallbacks test_codecs test_collections test_compile test_compileall test_complex test_concurrent_futures test_context test_contextlib test_coroutines test_cprofile test_csv test_ctypes test_datetime test_dbm test_dbm_sqlite3 test_decimal test_descr test_dict test_difflib test_dis test_doctest test_doctest2 test_docxmlrpc test_dtrace test_dynamic test_dynamicclassattribute test_email test_embed test_ensurepip test_enum test_enumerate test_eof test_except_star test_exceptions test_external_inspection test_faulthandler test_fcntl test_file test_file_eintr test_fileinput test_fileio test_float test_fork1 test_format test_fractions test_frame test_frozen test_functools test_future_stmt test_gc test_generated_cases test_generators test_genericpath test_genexps test_getopt test_glob test_grammar test_gzip test_hash test_hashlib test_http_cookiejar test_httpservers test_importlib test_inspect test_int test_io test_ioctl test_iter test_itertools test_json test_largefile test_launcher test_list test_listcomps test_locale test_logging test_long test_lzma test_mailbox test_marshal test_math test_memoryio test_memoryview test_metaclass test_mimetypes test_mmap test_monitoring test_msvcrt test_multibytecodec test_multiprocessing_main_handling test_netrc test_ntpath test_numeric_tower test_operator test_optparse test_ordered_dict test_os test_osx_env test_pathlib test_patma test_pdb test_peepholer test_perfmaps test_pickle test_pkg test_pkgutil test_platform test_plistlib test_popen test_posix test_posixpath test_print test_profile test_property test_pty test_pwd test_py_compile test_pyclbr test_pydoc test_pyexpat test_pyrepl test_quopri test_raise test_range test_re test_regrtest test_repl test_reprlib test_resource test_runpy test_sax test_scope test_script_helper test_select test_selectors test_shutil test_signal test_site test_slice test_smtplib test_socket test_sqlite3 test_ssl test_stable_abi_ctypes test_stat test_statistics test_str test_strftime test_string_literals test_strptime test_strtod test_struct test_subprocess test_support test_sys test_sys_setprofile test_sys_settrace test_sysconfig test_syslog test_tarfile test_tempfile test_termios test_threading test_threading_local test_threadsignals test_time test_timeit test_tomllib test_tools test_trace test_traceback test_tracemalloc test_tuple test_type_cache test_type_comments test_types test_typing test_unicode_file test_unicode_file_functions test_unicodedata test_unittest test_univnewlines test_urllib test_urllib2 test_urllib2net test_urlparse test_utf8_mode test_uuid test_venv test_wait3 test_wait4 test_wave test_weakref test_webbrowser test_winconsoleio test_winreg test_with test_wsgiref test_xml_etree test_xmlrpc test_xpickle test_zipapp test_zipfile test_zipfile64 test_zipimport test_zipimport_support test_zlib

[ ] test: cpython/Lib/test/test_pyrepl (TODO: 20)
[ ] test: cpython/Lib/test/test_repl.py (TODO: 7)

dependencies:

dependent tests: (no tests depend on pyrepl)

[x] lib: cpython/Lib/zipfile
[x] test: cpython/Lib/test/test_zipfile64.py

dependencies:

zipfile

dependent tests: (99 tests)

[x] lib: cpython/Lib/hmac.py
[ ] test: cpython/Lib/test/test_hmac.py (TODO: 12)

dependencies:

hmac

dependent tests: (9 tests)

hmac: test_hmac test_smtplib
- imaplib: test_imaplib
- multiprocessing.connection:
  - concurrent.futures.process: test_compileall test_concurrent_futures
- secrets: test_secrets
- smtplib: test_smtpnet
  - logging.handlers: test_logging test_pkgutil

[x] test: cpython/Lib/test/test_tuple.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on tuple)

[x] lib: cpython/Lib/socket.py
[ ] test: cpython/Lib/test/test_socket.py (TODO: 13)

dependencies:

socket

dependent tests: (101 tests)

[x] test: cpython/Lib/test/test_structseq.py (TODO: 1)

dependencies:

dependent tests: (no tests depend on structseq)

[x] lib: cpython/Lib/codecs.py
[x] test: cpython/Lib/test/test_charmapcodec.py
[ ] test: cpython/Lib/test/test_codeccallbacks.py (TODO: 3)
[x] test: cpython/Lib/test/test_codecencodings_cn.py
[x] test: cpython/Lib/test/test_codecencodings_hk.py
[x] test: cpython/Lib/test/test_codecencodings_iso2022.py
[x] test: cpython/Lib/test/test_codecencodings_jp.py
[x] test: cpython/Lib/test/test_codecencodings_kr.py
[x] test: cpython/Lib/test/test_codecencodings_tw.py
[x] test: cpython/Lib/test/test_codecmaps_cn.py
[x] test: cpython/Lib/test/test_codecmaps_hk.py
[x] test: cpython/Lib/test/test_codecmaps_jp.py
[x] test: cpython/Lib/test/test_codecmaps_kr.py
[x] test: cpython/Lib/test/test_codecmaps_tw.py
[ ] test: cpython/Lib/test/test_codecs.py (TODO: 4)
[x] test: cpython/Lib/test/test_multibytecodec.py
[x] test: cpython/Lib/test/testcodec.py

dependencies:

codecs

dependent tests: (161 tests)

[ ] lib: cpython/Lib/unittest
[ ] test: cpython/Lib/test/test_unittest (TODO: 2)

dependencies:

unittest (native: _io, _log, async_case, builtins, case, loader, main, os.path, result, runner, signals, suite, sys, time, unittest.util, util)
- asyncio (native: _asyncio, _overlapped, _pyrepl.console, _pyrepl.main, _pyrepl.simple_interact, _remote_debugging, _winapi, asyncio.tools, base_events, collections.abc, concurrent.futures, coroutines, errno, events, exceptions, futures, graph, itertools, locks, log, math, msvcrt, protocols, queues, readline, runners, streams, sys, taskgroups, tasks, threads, time, timeouts, transports, unix_events, windows_events)
- logging (native: atexit, collections.abc, email.message, email.utils, errno, http.client, logging.handlers, multiprocessing.queues, select, sys, time, urllib.parse, win32evtlog, win32evtlogutil)
- warnings
- _colorize, annotationlib, argparse, collections, contextlib, contextvars, dataclasses, difflib, fnmatch, functools, inspect, io, os, pkgutil, pprint, re, signal, threading, traceback, types, weakref

dependent tests: (408 tests)

unittest: regrtestdata test___all__ test__colorize test__locale test__opcode test__osx_support test_abc test_abstract_numbers test_android test_annotationlib test_apple test_argparse test_array test_asdl_parser test_ast test_asyncgen test_asyncio test_atexit test_audit test_augassign test_base64 test_baseexception test_bdb test_bigaddrspace test_bigmem test_binascii test_binop test_bisect test_bool test_buffer test_bufio test_builtin test_bytes test_bz2 test_c_locale_coercion test_calendar test_call test_charmapcodec test_class test_clinic test_cmath test_cmd test_cmd_line test_cmd_line_script test_code test_code_module test_codeccallbacks test_codecencodings_cn test_codecencodings_hk test_codecencodings_iso2022 test_codecencodings_jp test_codecencodings_kr test_codecencodings_tw test_codecmaps_cn test_codecmaps_hk test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw test_codecs test_codeop test_collections test_colorsys test_compare test_compile test_compileall test_complex test_concurrent_futures test_configparser test_contains test_context test_contextlib test_contextlib_async test_copy test_copyreg test_coroutines test_cprofile test_csv test_ctypes test_datetime test_dbm test_dbm_dumb test_dbm_sqlite3 test_decimal test_decorators test_defaultdict test_deque test_descr test_descrtut test_devpoll test_dict test_dictcomps test_dictviews test_difflib test_dis test_doctest test_doctest2 test_docxmlrpc test_dtrace test_dummy_thread test_dummy_threading test_dynamic test_dynamicclassattribute test_eintr test_email test_embed test_ensurepip test_enum test_enumerate test_eof test_epoll test_errno test_except_star test_exception_group test_exception_hierarchy test_exception_variations test_exceptions test_extcall test_external_inspection test_faulthandler test_fcntl test_file test_file_eintr test_filecmp test_fileinput test_fileio test_fileutils test_finalization test_float test_flufl test_fnmatch test_fork1 test_format test_fractions test_frame test_frozen test_fstring test_ftplib test_funcattrs test_functools test_future_stmt test_gc test_generated_cases test_generator_stop test_generators test_genericalias test_genericclass test_genericpath test_genexps test_getopt test_getpass test_gettext test_glob test_global test_grammar test_graphlib test_grp test_gzip test_hash test_hashlib test_heapq test_hmac test_html test_htmlparser test_http_cookiejar test_http_cookies test_httplib test_httpservers test_idle test_imaplib test_importlib test_index test_inspect test_int test_int_literal test_io test_ioctl test_ipaddress test_isinstance test_iter test_iterlen test_itertools test_json test_keyword test_keywordonlyarg test_kqueue test_largefile test_launcher test_linecache test_list test_listcomps test_locale test_logging test_long test_longexp test_lzma test_mailbox test_marshal test_math test_math_property test_memoryio test_memoryview test_metaclass test_mimetypes test_minidom test_mmap test_modulefinder test_monitoring test_msvcrt test_multibytecodec test_multiprocessing_fork test_multiprocessing_forkserver test_multiprocessing_main_handling test_multiprocessing_spawn test_named_expressions test_netrc test_ntpath test_nturl2path test_numeric_tower test_opcache test_opcodes test_openpty test_operator test_optimizer test_optparse test_ordered_dict test_os test_osx_env test_pathlib test_patma test_pdb test_peepholer test_peg_generator test_pep646_syntax test_perfmaps test_pickle test_picklebuffer test_pickletools test_pkg test_pkgutil test_platform test_plistlib test_poll test_popen test_poplib test_positional_only_arg test_posix test_posixpath test_pow test_pprint test_print test_profile test_property test_pstats test_pty test_pulldom test_pwd test_py_compile test_pyclbr test_pydoc test_pyexpat test_pyrepl test_queue test_quopri test_raise test_random test_range test_re test_regrtest test_repl test_reprlib test_resource test_richcmp test_rlcompleter test_robotparser test_runpy test_sax test_sched test_scope test_script_helper test_secrets test_select test_selectors test_set test_setcomps test_shelve test_shlex test_shutil test_signal test_site test_slice test_smtplib test_smtpnet test_socket test_socketserver test_sort test_sqlite3 test_ssl test_stable_abi_ctypes test_stat test_statistics test_str test_strftime test_string test_string_literals test_stringprep test_strptime test_strtod test_struct test_structseq test_subclassinit test_subprocess test_sundry test_super test_support test_symtable test_syntax test_sys test_sys_setprofile test_sys_settrace test_sysconfig test_syslog test_tabnanny test_tarfile test_tempfile test_termios test_textwrap test_thread test_thread_local_bytecode test_threadedtempfile test_threading test_threading_local test_threadsignals test_time test_timeit test_timeout test_tokenize test_tomllib test_tools test_trace test_traceback test_tracemalloc test_tstring test_tty test_tuple test_turtle test_type_aliases test_type_annotations test_type_cache test_type_comments test_type_params test_typechecks test_types test_typing test_ucn test_unary test_unicode_file test_unicode_file_functions test_unicode_identifiers test_unicodedata test_unittest test_univnewlines test_unpack test_unpack_ex test_unparse test_urllib test_urllib2 test_urllib2_localnet test_urllib2net test_urllib_response test_urllibnet test_urlparse test_userdict test_userlist test_userstring test_utf8_mode test_utf8source test_uuid test_venv test_wait3 test_wait4 test_wave test_weakref test_weakset test_webbrowser test_winapi test_winconsoleio test_winreg test_winsound test_with test_wmi test_wsgiref test_xml_dom_minicompat test_xml_dom_xmlbuilder test_xml_etree test_xml_etree_c test_xmlrpc test_xpickle test_xxlimited test_xxtestfuzz test_yield_from test_zipapp test_zipfile test_zipfile64 test_zipimport test_zipimport_support test_zlib test_zoneinfo test_zstd

[x] lib: cpython/Lib/functools.py
[ ] test: cpython/Lib/test/test_functools.py (TODO: 9)

dependencies:

functools

dependent tests: (51 tests)

functools: test_annotationlib test_argparse test_asyncio test_builtin test_bytes test_call test_clinic test_codeop test_context test_contextlib_async test_ctypes test_datetime test_dbm_dumb test_dbm_sqlite3 test_dis test_doctest test_enum test_fileio test_fractions test_functools test_genericalias test_gettext test_gzip test_hmac test_inspect test_iter test_itertools test_math_property test_monitoring test_posixpath test_py_compile test_pyexpat test_pyrepl test_random test_repl test_reprlib test_shutil test_signal test_sort test_sqlite3 test_ssl test_sys_settrace test_timeout test_traceback test_typing test_unicodedata test_unittest test_webbrowser test_winsound test_xml_etree test_zoneinfo

[ ] lib: cpython/Lib/http
[ ] test: cpython/Lib/test/test_httplib.py (TODO: 1)
[x] test: cpython/Lib/test/test_http_cookiejar.py
[x] test: cpython/Lib/test/test_http_cookies.py (TODO: 1)
[ ] test: cpython/Lib/test/test_httpservers.py

dependencies:

http (native: binascii, collections.abc, email.message, email.parser, email.utils, errno, http.client, itertools, pwd, select, sys, time, urllib.parse, urllib.request)
- logging, warnings
- argparse, base64, calendar, contextlib, copy, datetime, enum, html, io, mimetypes, os, posixpath, re, shutil, socket, socketserver, ssl, string, subprocess, threading, traceback, types

dependent tests: (51 tests)

http: test_docxmlrpc test_genericalias test_hashlib test_http_cookiejar test_http_cookies test_httplib test_httpservers test_logging test_robotparser test_ssl test_ucn test_unicodedata test_urllib test_urllib2 test_urllib2_localnet test_wsgiref test_xml_dom_xmlbuilder test_xmlrpc
- logging.handlers: test_concurrent_futures test_pkgutil
- pydoc: test_enum test_pydoc
  - pdb: test_pdb
- urllib.request: test_pathlib test_sax test_site test_urllib2net test_urllibnet
  - pathlib: test_ast test_dbm_sqlite3 test_ensurepip test_importlib test_json test_launcher test_os test_pathlib test_peg_generator test_pyrepl test_runpy test_tarfile test_tempfile test_tomllib test_tools test_traceback test_unparse test_venv test_winapi test_zipapp test_zipfile test_zoneinfo test_zstd

[x] test: cpython/Lib/test/test_float.py (TODO: 2)
[x] test: cpython/Lib/test/test_strtod.py

dependencies:

dependent tests: (no tests depend on float)

[x] test: cpython/Lib/test/test_marshal.py (TODO: 4)

dependencies:

dependent tests: (25 tests)

marshal: test_bool test_exceptions test_importlib test_inspect test_marshal test_zipimport
- importlib._bootstrap_external: test_importlib test_unittest
  - modulefinder: test_importlib test_modulefinder
  - py_compile: test_argparse test_cmd_line_script test_compileall test_importlib test_multiprocessing_main_handling test_py_compile test_pydoc test_runpy
  - pydoc: test_enum
- pkgutil: test_pkgutil test_pyrepl
- profile: test_profile
- pstats: test_pstats
- zipimport: test_importlib test_zipimport_support

[x] lib: cpython/Lib/dataclasses.py
[x] test: cpython/Lib/test/test_dataclasses (TODO: 1)

dependencies:

dataclasses

dependent tests: (98 tests)

dataclasses: test__colorize test_copy test_ctypes test_enum test_genericalias test_patma test_pprint test_pydoc test_regrtest test_typing test_zoneinfo
- pprint: test_htmlparser test_ssl test_sys_setprofile test_unittest
  - pdb: test_pdb
  - pickle: test_annotationlib test_argparse test_array test_ast test_asyncio test_bool test_builtin test_bytes test_bz2 test_codecs test_collections test_concurrent_futures test_configparser test_coroutines test_csv test_ctypes test_decimal test_defaultdict test_deque test_descr test_dict test_dictviews test_email test_enumerate test_exceptions test_fractions test_functools test_generators test_http_cookies test_importlib test_inspect test_io test_ipaddress test_iter test_itertools test_list test_logging test_lzma test_memoryio test_memoryview test_minidom test_opcache test_operator test_ordered_dict test_os test_pathlib test_pickle test_picklebuffer test_pickletools test_platform test_plistlib test_positional_only_arg test_posix test_random test_range test_re test_set test_shelve test_slice test_socket test_statistics test_str test_string test_structseq test_super test_time test_trace test_tuple test_turtle test_type_aliases test_type_params test_types test_unittest test_uuid test_xml_dom_minicompat test_xml_etree test_xpickle test_zipfile test_zlib test_zoneinfo
- pstats: test_profile test_pstats

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

Merge current main and reuse its complex format types and unpacking. Keep only conversion, warning, and opposite-endian overflow fixes. Codex assisted with conflict resolution, implementation, tests, and review. Constraint: F/D format support is already present in upstream RustPython#8780 Tested: CPython 3.14.7 comparison; struct/memoryview/complex/cmath; pytest; workspace and C-API tests; Clippy; prek Assisted-by: Codex:gpt-6-astra

codspeed · 2026-09-26T06:54:15Z

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks¹

_{Comparing doma17:fix-struct-complex-formats (acc3605) with main (7f314dd)}

4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

youknowone

👍

doma17 changed the title ~~Support struct complex formats F and D~~ Fix struct complex conversion and overflow behavior Sep 26, 2026

youknowone approved these changes Sep 26, 2026

View reviewed changes

youknowone merged commit 5f18b9c into RustPython:main Sep 26, 2026
29 of 30 checks passed

Navigation Menu

Repository navigation

Fix struct complex conversion and overflow behavior - #8829

Fix struct complex conversion and overflow behavior#8829
youknowone merged 2 commits into
RustPython:mainfrom
doma17:fix-struct-complex-formats

doma17 commented Sep 26, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Sep 26, 2026

Uh oh!

coderabbitai Bot commented Sep 26, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 26, 2026

Uh oh!

codspeed Bot commented Sep 26, 2026

Uh oh!

youknowone left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

doma17 commented Sep 26, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Sep 26, 2026

Uh oh!

coderabbitai Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

❌ Failed checks (1 warning)

Uh oh!

github-actions Bot commented Sep 26, 2026

📦 Library Dependencies

Uh oh!

codspeed Bot commented Sep 26, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

youknowone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

doma17 commented Sep 26, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 26, 2026 •

edited

Loading