Skip to content

Read tuple, bytes, int, float and complex payloads through views on Py<T> #8819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 12 commits into from
Sep 26, 2026
Merged

Read tuple, bytes, int, float and complex payloads through views on Py<T> #8819

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bc3432d
Read PyTuple payloads through as_slice()
youknowone Sep 25, 2026
2a111ef
Read PyBytes payloads through as_bytes()
youknowone Sep 25, 2026
722b034
Copy capi tuple arguments with as_slice().to_vec()
youknowone Sep 25, 2026
89c713f
Read sqlite3 Row tuples through as_slice()
youknowone Sep 25, 2026
febea26
Read platform-specific tuples and bytes through as_slice() and as_byt…
youknowone Sep 25, 2026
07fade3
Read PyInt and PyFloat payloads through as_bigint() and to_f64()
youknowone Sep 26, 2026
1616e12
Read PyComplex payloads through as_complex()
youknowone Sep 26, 2026
89fa925
Move PyInt conversion helpers to Py<PyInt>
youknowone Sep 26, 2026
38f83b5
Share one conversion between try_to_primitive() and its OverflowError…
youknowone Sep 26, 2026
0952947
Move PyInt bitwise operators to Py<PyInt>
youknowone Sep 26, 2026
0d1e70b
Move PyBytes operators to Py<PyBytes>
youknowone Sep 26, 2026
e92674f
Move PyInt general_op() and modpow() to Py<PyInt>
youknowone Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Read sqlite3 Row tuples through as_slice() 
Assisted-by: Claude Code:claude-opus-5-5
  • Loading branch information
@youknowone
youknowone committed Sep 26, 2026
commit 89c713fb42bedf12b9f7b0cc8ced162207b50175
19 changes: 14 additions & 5 deletions crates/stdlib/src/_sqlite3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2372,6 +2372,7 @@ mod _sqlite3 {
#[pymethod]
fn keys(&self, _vm: &VirtualMachine) -> Vec<PyObjectRef> {
self.description
.as_slice()
.iter()
.map(|x| x.downcast_ref::<PyTuple>().unwrap().as_slice()[0].clone())
.collect()
Expand All @@ -2380,9 +2381,9 @@ mod _sqlite3 {
fn subscript(&self, needle: &PyObject, vm: &VirtualMachine) -> PyResult {
if let Some(i) = needle.downcast_ref::<PyInt>() {
let i = i.try_to_primitive::<isize>(vm)?;
self.data.getitem_by_index(vm, i)
self.data.as_slice().getitem_by_index(vm, i)
} else if let Some(name) = needle.downcast_ref::<PyStr>() {
for (obj, i) in self.description.iter().zip(0..) {
for (obj, i) in self.description.as_slice().iter().zip(0..) {
let obj = &obj.downcast_ref::<PyTuple>().unwrap().as_slice()[0];
let Some(obj) = obj.downcast_ref::<PyStr>() else {
break;
Expand All @@ -2391,12 +2392,15 @@ mod _sqlite3 {
let b_iter = obj.expect_str().chars().flat_map(|x| x.to_uppercase());

if a_iter.eq(b_iter) {
return self.data.getitem_by_index(vm, i);
return self.data.as_slice().getitem_by_index(vm, i);
}
}
Err(vm.new_index_error(format!("No item with key '{}'", name.to_string_lossy())))
} else if let Some(slice) = needle.downcast_ref::<PySlice>() {
let list = self.data.getitem_by_slice(vm, slice.to_saturated(vm)?)?;
let list = self
.data
.as_slice()
.getitem_by_slice(vm, slice.to_saturated(vm)?)?;
Ok(vm.ctx.new_tuple(list).into())
} else {
Err(vm.new_index_error("Index must be int or string"))
Expand Down Expand Up @@ -2460,6 +2464,7 @@ mod _sqlite3 {
std::sync::LazyLock::new(|| PyMappingMethods {
length: atomic_func!(|mapping, _vm| Ok(Row::mapping_downcast(mapping)
.data
.as_slice()
.len())),
subscript: atomic_func!(|mapping, needle, vm| {
Row::mapping_downcast(mapping).subscript(needle, vm)
Expand All @@ -2474,9 +2479,13 @@ mod _sqlite3 {
fn as_sequence() -> &'static PySequenceMethods {
static AS_SEQUENCE: std::sync::LazyLock<PySequenceMethods> =
std::sync::LazyLock::new(|| PySequenceMethods {
length: atomic_func!(|seq, _vm| Ok(Row::sequence_downcast(seq).data.len())),
length: atomic_func!(|seq, _vm| Ok(Row::sequence_downcast(seq)
.data
.as_slice()
.len())),
item: atomic_func!(|seq, i, vm| Row::sequence_downcast(seq)
.data
.as_slice()
.getitem_by_index(vm, i)),
..PySequenceMethods::NOT_IMPLEMENTED
});
Expand Down