Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -456,9 +456,6 @@
RUST_BACKTRACE: full
# Tests that can be flaky when running with multiple processes `-j 2`. We will use `-j 1` for these.
FLAKY_MP_TESTS: >-
test_class
test_concurrent_futures
test_eintr
test_multiprocessing_fork
test_multiprocessing_forkserver
test_multiprocessing_spawn
Expand All @@ -475,6 +472,7 @@
- '-u all'
- '--timeout 600'
- '--dont-add-python-opts'
extra_flaky_mp_tests: []
env_polluting_tests: []
skips: []
timeout: 50
Expand All @@ -483,6 +481,7 @@
- '-u all'
- '--timeout 600'
- '--dont-add-python-opts'
extra_flaky_mp_tests: []
env_polluting_tests: []
skips: []
timeout: 60
Expand All @@ -491,6 +490,7 @@
- '-u all'
- '--timeout 600'
- '--dont-add-python-opts'
extra_flaky_mp_tests: []
env_polluting_tests: []
skips: []
timeout: 50
Expand Down Expand Up @@ -551,19 +551,24 @@
echo "cores=${cores}" >> "$GITHUB_OUTPUT"

- name: Run CPython tests
run: |

Check warning on line 554 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / Lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:1:96: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/ci.yaml:554:9: shellcheck reported issue in this script: SC2086:info:1:96: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 554 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / Lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:1:80: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/ci.yaml:554:9: shellcheck reported issue in this script: SC2086:info:1:80: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 554 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / Lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/ci.yaml:554:9: shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 554 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / Lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:1:118: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/ci.yaml:554:9: shellcheck reported issue in this script: SC2086:info:1:118: Double quote to prevent globbing and word splitting [shellcheck]
target/release/rustpython -u -m test --slow-ci -j ${{ steps.cores.outputs.cores }} ${{ join(matrix.extra_test_args, ' ') }} -x ${{ env.FLAKY_MP_TESTS }} ${{ join(matrix.skips, ' ') }}
target/release/rustpython -u -m test --slow-ci -j "$CORES" $EXTRA_TEST_ARGS -x $FLAKY_MP_TESTS $EXTRA_FLAKY_MP_TESTS $SKIPS
timeout-minutes: ${{ matrix.timeout }}
shell: bash
env:
RUSTPYTHON_SKIP_ENV_POLLUTERS: true
CORES: ${{ steps.cores.outputs.cores }}
EXTRA_TEST_ARGS: ${{ join(matrix.extra_test_args, ' ') }}
EXTRA_FLAKY_MP_TESTS: ${{ join(matrix.extra_flaky_mp_tests, ' ') }}
SKIPS: ${{ join(matrix.skips, ' ') }}

- name: Run flaky MP CPython tests
run: |

Check warning on line 566 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / Lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:5:88: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/ci.yaml:566:9: shellcheck reported issue in this script: SC2086:info:5:88: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 566 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / Lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:5:72: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/ci.yaml:566:9: shellcheck reported issue in this script: SC2086:info:5:72: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 566 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / Lint

[actionlint] reported by reviewdog 🐶 shellcheck reported issue in this script: SC2086:info:5:55: Double quote to prevent globbing and word splitting [shellcheck] Raw Output: i:.github/workflows/ci.yaml:566:9: shellcheck reported issue in this script: SC2086:info:5:55: Double quote to prevent globbing and word splitting [shellcheck]
for attempt in $(seq 1 5); do
echo "::group::Attempt ${attempt}"

set +e
target/release/rustpython -u -m test --slow-ci -j 1 ${{ join(matrix.extra_test_args, ' ') }} ${{ env.FLAKY_MP_TESTS }}
target/release/rustpython -u -m test --slow-ci -j 1 $EXTRA_TEST_ARGS $FLAKY_MP_TESTS $EXTRA_FLAKY_MP_TESTS
status=$?
set -e

Expand All @@ -579,6 +584,8 @@
shell: bash
env:
RUSTPYTHON_SKIP_ENV_POLLUTERS: true
EXTRA_TEST_ARGS: ${{ join(matrix.extra_test_args, ' ') }}
EXTRA_FLAKY_MP_TESTS: ${{ join(matrix.extra_flaky_mp_tests, ' ') }}

- name: run cpython tests to check if env polluters have stopped polluting
shell: bash
Expand Down Expand Up @@ -737,12 +744,13 @@

- uses: dtolnay/rust-toolchain@stable

- uses: cargo-bins/cargo-binstall@b874e25ea559687bec77e281e9b271aa1367b624 # v1.23.0
- uses: taiki-e/install-action@d438492cf8a250514fa2d34b30bc3c0dc37c65ff # v2.87.8
with:
tool: cargo-shear
fallback: none

- name: cargo shear
run: |
cargo binstall --no-confirm cargo-shear
cargo shear --locked
run: cargo shear --locked

lint:
name: Lint
Expand Down
1 change: 0 additions & 1 deletion Lib/test/_test_multiprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -1606,7 +1606,6 @@ def _acquire_release(lock, timeout, l=None, n=1):
for _ in range(n):
lock.release()

@unittest.skip("TODO: RUSTPYTHON; flaky timeout - thread start latency")
def test_repr_rlock(self):
if self.TYPE != 'processes':
self.skipTest('test not appropriate for {}'.format(self.TYPE))
Expand Down
5 changes: 0 additions & 5 deletions Lib/test/test_concurrent_futures/test_shutdown.py
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,6 @@ def test_cancel_futures_wait_false(self):


class ProcessPoolShutdownTest(ExecutorShutdownTest):
# TODO: RUSTPYTHON - flaky, dict changed size during iteration race condition
@unittest.skip("TODO: RUSTPYTHON - flaky race condition on macOS")
def test_cancel_futures(self):
return super().test_cancel_futures()

def test_processes_terminate(self):
def acquire_lock(lock):
lock.acquire()
Expand Down
55 changes: 0 additions & 55 deletions benches/benchmarks/gc_collect.py

This file was deleted.

1 change: 0 additions & 1 deletion tests/benchmark_scripts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ const PYPERFORMANCE_BENCHMARKS: &[&str] = &[
"deepcopy.py",
"deltablue.py",
"float.py",
"gc_collect.py",
"gc_traversal.py",
"generators.py",
"json_dumps.py",
Expand Down
Loading