Skip to content

builtins: generate accurate __text_signature__ #8512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 9 commits into from
Aug 18, 2026
Merged

builtins: generate accurate __text_signature__ #8512

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6725e25
Drop the $module marker from generated __text_signature__
leehanjeong Aug 10, 2026
7978ea4
Mark generated __text_signature__ parameters positional-only
leehanjeong Aug 10, 2026
34eab71
Emit no __text_signature__ when an argument has no name
leehanjeong Aug 10, 2026
7b614ca
Name builtin parameters after CPython
leehanjeong Aug 10, 2026
811b5b3
Drop expectedFailure from test_module_level_callable_noargs
leehanjeong Aug 10, 2026
4e41ace
Guard the signature-less assertions to RustPython
leehanjeong Aug 10, 2026
a1ef412
Merge branch 'main' into 8383-text-signature-fix
youknowone Aug 18, 2026
ce81d4d
Update crates/derive-impl/src/util.rs
youknowone Aug 18, 2026
611744d
Fix ord's parameter reference after the merge
leehanjeong Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Drop the $module marker from generated __text_signature__ 
CPython's C functions receive the module as their first argument, so
PyCFunction.__self__ is the module and inspect strips the $module
parameter when building a Signature. A #[pyfunction] takes no such
argument, PyNativeFunction::zelf is None, and inspect has nothing to
strip, so the marker surfaced as a parameter that does not exist:

    inspect.signature(len)
    (module, /, obj)     # was
    (obj)                # now

All 45 builtins shared with CPython carried it. Methods are unaffected;
their $self marker comes from func_sig and both branches now produce the
same string.

Assisted-by: Claude Code:claude-opus-5
  • Loading branch information
@leehanjeong
leehanjeong committed Aug 11, 2026
commit 6725e25a326be501dde7111dcf7b73b94af894d6
9 changes: 4 additions & 5 deletions crates/derive-impl/src/util.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,13 +732,12 @@ where

// Best effort attempt to generate a template from which a
// __text_signature__ can be created.
//
// Unlike CPython, a `#[pyfunction]` doesn't take the module as an argument,
Comment thread
youknowone marked this conversation as resolved.
Outdated
// so there's no module to mark with `$module`.
pub(crate) fn text_signature(sig: &Signature, name: &str) -> String {
let signature = func_sig(sig);
if signature.starts_with("$self") {
format!("{name}({signature})")
} else {
format!("{}({}, {})", name, "$module", signature)
}
format!("{name}({signature})")
}

pub(crate) fn infer_native_call_flags(sig: &Signature, drop_first_typed: usize) -> TokenStream {
Expand Down