Skip to content

Add seekable() to mmap.mmap #8405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Jul 29, 2026
Merged

Add seekable() to mmap.mmap #8405

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f92e566
Allow mmap-backed readers to identify seek support
doma17 Jul 28, 2026
180979c
Keep mmap regression test lint-clean
doma17 Jul 28, 2026
77dd0e9
Keep mmap seekability method conventional
doma17 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/stdlib/src/mmap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,6 +1141,11 @@ mod mmap {
self.pos()
}

#[pymethod]
const fn seekable(&self) -> bool {
true
}
Comment thread
doma17 marked this conversation as resolved.
Comment thread
doma17 marked this conversation as resolved.

#[pymethod]
fn write(&self, bytes: ArgBytesLike, vm: &VirtualMachine) -> PyResult<PyIntRef> {
let pos = self.pos();
Expand Down
6 changes: 6 additions & 0 deletions extra_tests/snippets/stdlib_mmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import mmap

mapped = mmap.mmap(-1, 1)
assert mapped.seekable()
mapped.close()
assert mapped.seekable()
Loading