Skip to content

Move some free standing functions to ir::InstructionInfo methods #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
Jul 4, 2026
Merged

Move some free standing functions to ir::InstructionInfo methods #8209

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9668e6a
Move some free standing functions to methods
ShaharNaveh Jul 2, 2026
ed0156c
align tests
ShaharNaveh Jul 3, 2026
5456caf
mark loads_const as const fn
ShaharNaveh Jul 3, 2026
c25019a
coderabbit suggestion
ShaharNaveh Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mark loads_const as const fn
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jul 3, 2026
commit 5456caf6b0ac73a3995dc1213c91c0b7a73f981e
2 changes: 1 addition & 1 deletion crates/codegen/src/ir.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ impl InstructionInfo {
}

/// flowgraph.c loads_const
fn loads_const(&self) -> bool {
const fn loads_const(&self) -> bool {
self.instr.has_const() || matches!(self.instr.real_opcode(), Some(Opcode::LoadSmallInt))
}

Expand Down
Loading