Skip to content

Add more clippy rules #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 7 commits into from
Jun 30, 2026
Merged

Add more clippy rules #8183

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
afc1189
clippy `assigning_clones`
ShaharNaveh Jun 27, 2026
f40f756
string_lit_as_bytes
ShaharNaveh Jun 27, 2026
49d697b
tuple_array_conversions
ShaharNaveh Jun 27, 2026
f7163ee
while_float
ShaharNaveh Jun 27, 2026
e1d1331
manual_assert
ShaharNaveh Jun 27, 2026
8fe18a2
Revert "string_lit_as_bytes"
ShaharNaveh Jun 28, 2026
5bf2a0c
fix jit
ShaharNaveh Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
manual_assert
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jun 27, 2026
commit e1d133163b637c2e393982ee8e064355dd2d4acd
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
flamescope = { version = "0.1.2", optional = true }

rustls = { workspace = true, optional = true }
rustls-graviola = { workspace = true, optional = true }

Check warning on line 52 in Cargo.toml

View workflow job for this annotation

GitHub Actions / cargo shear

shear/misplaced_optional_dependency 

misplaced optional dependency `rustls-graviola` (remove the `optional` flag and move to `[dev-dependencies]`)

[target.'cfg(windows)'.dependencies]
libc = { workspace = true }
Expand Down Expand Up @@ -407,6 +407,7 @@
iter_filter_is_some = "warn"
large_futures = "warn"
large_types_passed_by_value = "warn"
manual_assert = "warn"
manual_instant_elapsed = "warn"
manual_is_variant_and = "warn"
map_unwrap_or = "warn"
Expand Down
7 changes: 4 additions & 3 deletions crates/vm/src/function/builtin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ const fn zst_ref_out_of_thin_air<T: 'static>(x: T) -> &'static T {
// operation. if T isn't zero-sized, we don't have to worry about it because we'll fail to compile.
core::mem::forget(x);
const {
if core::mem::size_of::<T>() != 0 {
panic!("can't use a non-zero-sized type here")
}
assert!(
core::mem::size_of::<T>() == 0,
"can't use a non-zero-sized type here"
);
// SAFETY: we just confirmed that T is zero-sized, so we can
// pull a value of it out of thin air.
unsafe { core::ptr::NonNull::<T>::dangling().as_ref() }
Expand Down
9 changes: 4 additions & 5 deletions crates/vm/src/types/slot.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1667,11 +1667,10 @@ pub trait Initializer: PyPayload {
.matches(&class_name_for_debug as &str)
.count()
== 2;
if double_appearance {
panic!(
"This type `{class_name_for_debug}` doesn't seem to support `init`. Override `slot_init` instead: {msg}"
);
}
assert!(
!double_appearance,
"This type `{class_name_for_debug}` doesn't seem to support `init`. Override `slot_init` instead: {msg}"
)
}
}
return Err(err);
Expand Down
4 changes: 1 addition & 3 deletions crates/vm/src/vm/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,9 +883,7 @@ impl VirtualMachine {
fn initialize(&mut self) {
flame_guard!("init VirtualMachine");

if self.initialized {
panic!("Double Initialize Error");
}
assert!(!self.initialized, "Double Initialize Error");

// Initialize main thread ident before any threading operations
#[cfg(feature = "threading")]
Expand Down
Loading