Skip to content

Align compiler and AST behavior with CPython #8138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 15 commits into from
Jun 26, 2026
Merged

Align compiler and AST behavior with CPython #8138

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b28ef35
Align compiler and AST behavior with CPython
youknowone Jun 22, 2026
c6769a4
fix
youknowone Jun 23, 2026
113992e
Fix PR 8138 CI failures
youknowone Jun 23, 2026
1b0237a
Fix match mapping wildcard scan complexity
youknowone Jun 23, 2026
eb0a2ad
fixes
youknowone Jun 24, 2026
31c17a2
Use Ruff runtime AST fields
youknowone Jun 25, 2026
c1462fa
Minimize residual patch diff
youknowone Jun 25, 2026
ca82736
refactor error handling
youknowone Jun 25, 2026
0f38041
Remove _ast conversion context wrappers
youknowone Jun 25, 2026
f13e07c
Clean up _ast conversion glue and compiler warning escalation
youknowone Jun 25, 2026
aa70df4
Represent compiler flags as a CompilerFlags bitflags
youknowone Jun 25, 2026
345277f
Fix PR 8138 test regressions
youknowone Jun 25, 2026
f649f67
Fix PR 8138 CI failures
youknowone Jun 26, 2026
a52b8e8
Avoid shell interpolation in Linux deps action
youknowone Jun 26, 2026
462ef24
Fix review findings in compiler/AST changes
youknowone Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PR 8138 CI failures
  • Loading branch information
@youknowone
youknowone committed Jun 25, 2026
commit 113992e7fbe7317a0f809f14c97b1bd88c58bad5
1 change: 0 additions & 1 deletion Lib/test/test_audit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ def test_monkeypatch(self):
def test_open(self):
self.do_test("test_open", os_helper.TESTFN)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_cantrace(self):
self.do_test("test_cantrace")

Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_sys_setprofile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ def g(p):
(1, 'return', g_ident),
])

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_exception_propagation(self):
def f(p):
1/0
Expand Down
7 changes: 4 additions & 3 deletions crates/codegen/src/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14141,9 +14141,10 @@ mod tests {
ruff_python_ast::Mod::Module(stmts) => stmts,
_ => unreachable!(),
};
let symbol_table = SymbolTable::scan_program(&ast, source_file.clone())
.map_err(|e| e.into_codegen_error(source_file.name().to_owned()))
.unwrap();
let symbol_table = match SymbolTable::scan_program(&ast, source_file.clone()) {
Ok(symbol_table) => symbol_table,
Err(err) => return err.into_codegen_error(source_file.name().to_owned()),
};
let mut compiler =
Compiler::new_with_syntax_warning_handler(opts, source_file, "<module>", None);
compiler.compile_program(&ast, symbol_table).unwrap_err()
Expand Down