Skip to content

Add set_attrs! macro for setting multiple attributes on an object #8034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 8 commits into from
Jun 9, 2026
Merged

Add set_attrs! macro for setting multiple attributes on an object #8034

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aa60e4c
Base macro
ShaharNaveh Jun 3, 2026
6177f89
Use `set_attrs` macro
ShaharNaveh Jun 3, 2026
e53219d
More
ShaharNaveh Jun 3, 2026
0efda44
Fix typo
ShaharNaveh Jun 3, 2026
e8b834c
Merge remote-tracking branch 'upstream/main' into set-attrs-macro
ShaharNaveh Jun 3, 2026
78a1fdb
Merge remote-tracking branch 'upstream/main' into set-attrs-macro
ShaharNaveh Jun 4, 2026
98dc062
Apply coderabbit suggestion
ShaharNaveh Jun 4, 2026
ae7770b
clippy
ShaharNaveh Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Base macro
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jun 3, 2026
commit aa60e4c677920281b4a1a3a88d92ae574eadb91e
15 changes: 15 additions & 0 deletions crates/vm/src/protocol/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,3 +826,18 @@ impl PyObject {
}
}
}

/// Macro to reduce code repition when setting multiple attributes on an object.
#[macro_export]
macro_rules! set_attrs {
($obj:expr, $vm:expr, unwrap, $($key:expr => $val:expr),+ $(,)?) => {
$(
$obj.set_attr($key, $val, $vm).unwrap();
)+
};
($obj:expr, $vm:expr, $($key:expr => $val:expr),+ $(,)?) => {
$(
$obj.set_attr($key, $val, $vm)?;
)+
};
}