Skip to content

[DO NOT MERGE] Almost complete rustls integration rewrite #8007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
im-0 wants to merge 25 commits into
base: main
Choose a base branch
from
+10,017 −9,543
Draft

[DO NOT MERGE] Almost complete rustls integration rewrite #8007

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
0cf37b3
Add a test for ssl with ssl.MemoryBIO
im-0 May 24, 2026
d625289
Add Serde serializer that converts structs into basic Python objects
im-0 May 26, 2026
ce22219
Support module monkey-patching on VM level
im-0 May 30, 2026
cac2ee7
Add OpenSSL data files used to build OID and NID tables
im-0 May 27, 2026
a54bbf0
Enable/disable ssl-related tests from cpython test suite
im-0 May 30, 2026
1e25e1a
Revert "Skip flaky tests (#7961)"
im-0 May 31, 2026
2cda4d8
Revert "Skip flaky test (#7967)"
im-0 May 31, 2026
0cb9242
Almost a complete rewrite of rustls integration
im-0 May 24, 2026
60cf7e1
Skip test.test_httplib.HTTPSTest.test_networked_good_cert if rustls i…
im-0 Jun 1, 2026
d06b7f5
On client, both CERT_OPTIONAL and CERT_REQUIRED enable cert verification
im-0 Jun 2, 2026
3acc916
Rename stdlib_ssl_bio_unencrypted_trailer.py -> stdlib_ssl.py
im-0 Jun 3, 2026
c5be311
Move crates/stdlib/src/rustls-data -> crates/stdlib/rustls-data
im-0 Jun 3, 2026
489cd9c
Use expectedFailureIf() instead of skipIf() for rustls-specific skips
im-0 Jun 3, 2026
f2f3f2a
Fix `cargo shear` warn (graviola dep for examples/custom_tls_provider…
im-0 Jun 3, 2026
cdd4433
Call SNI callback earlier and re-read the context after it
im-0 Jun 3, 2026
9bb9e45
Remove allow_threads() from rustls integration
im-0 Jun 3, 2026
bc9d497
Use certs from both SSL_CERT_FILE and SSL_CERT_DIR env vars if present
im-0 Jun 3, 2026
76c92ae
Keep rustls error in SslError until converted into Python error
im-0 Jun 3, 2026
e3c9596
Ensure that TLS alerts are sent back on TLS errors
im-0 Jun 3, 2026
bb0d7ef
Document TLS connection state machine
im-0 Jun 4, 2026
02eb49f
Test Rust -> Python serializer with py_serde::PyObjectSerializer
im-0 Jun 4, 2026
a25d257
Add documentation for Rust -> Python serializer
im-0 Jun 4, 2026
29013e3
Serialize unit struct into Python string with just a struct name
im-0 Jun 4, 2026
596b0da
Enable ThreadedTests.test_ssl_in_multiple_threads
im-0 Jun 4, 2026
f7117cf
Workaround for test.test_ssl.ThreadedTests.test_wrong_cert_tls*
im-0 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
On client, both CERT_OPTIONAL and CERT_REQUIRED enable cert verification
  • Loading branch information
@im-0
im-0 committed Jun 4, 2026
commit d06b7f5c6666a64fe3df7f4ace551538d2500e20
2 changes: 1 addition & 1 deletion crates/stdlib/src/rustls.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,7 +1162,7 @@ mod _ssl {
};

let verifier = CustomServerCertVerifier::new(
self.verify_mode() == CERT_REQUIRED,
self.verify_mode() != CERT_NONE,
use_system_certificates,
&self.cert_store.read(),
crypto.clone(),
Expand Down