Skip to content

sqlite3: fix Blob.__setitem__ value range validation #7981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
May 27, 2026
Merged

sqlite3: fix Blob.__setitem__ value range validation #7981

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95abd48
sqlite3: fix Blob.__setitem__ value range validation
ever0de May 26, 2026
6f3eae8
sqlite3: fix Blob.__setitem__ negative-step slice write
ever0de May 26, 2026
1df29c5
fix: guard blob negative-step snippet from CPython 3.11 bug
ever0de May 26, 2026
c074556
style: add blank line after import sys in stdlib_sqlite snippet (ruff)
ever0de May 26, 2026
57accdb
Update extra_tests/snippets/stdlib_sqlite.py
youknowone May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update extra_tests/snippets/stdlib_sqlite.py
  • Loading branch information
@youknowone
youknowone authored May 27, 2026
commit 57accdbca3328186c8bc873390b5a7de8d4f777d
1 change: 1 addition & 0 deletions extra_tests/snippets/stdlib_sqlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ def finalize(self):
# Blob extended-slice assignment with negative step
# Guard: CPython 3.11 has a SystemError bug with negative-step Blob slicing;
# this test only runs on RustPython where the fix is being validated.
Comment thread
youknowone marked this conversation as resolved.
# TODO: remove this once https://github.com/python/cpython/pull/150450 is released and RustPython CI uses it.
import sys

if sys.implementation.name == "rustpython":

@youknowone youknowone May 26, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually don't add rustpython-only code. is this CPython bug? Then is this reported to CPython?

@ever0de ever0de May 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the negative-step slice crash is a CPython bug — I've filed it upstream as python/cpython#150449 and submitted a fix PR (python/cpython#150450).

However, this PR also contains a few pre-existing RustPython-only bugs unrelated to that CPython issue:

  • blob[i] = v was using try_to_primitive::<u8> which silently gave the wrong error for out-of-range values (e.g. 256 or -1), instead of CPython's ValueError: byte must be in range(0, 256)
  • The item-deletion vs. slice-deletion error messages were swapped

Should I split this into two PRs — one for the CPython-mirrored negative-step fix (which could be reverted or marked TODO: RUSTPYTHON until upstream lands), and one for the RustPython-specific behavior alignment?

Expand Down
Loading