Skip to content

Rustls integration improvements #7946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 11 commits into from
May 22, 2026
Merged

Rustls integration improvements #7946

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ad3060c
Do not call `import socket` on each send()/recv() when using rustls
im-0 May 18, 2026
7fa757d
Implement reading of at most one TLS record from socket
im-0 May 18, 2026
bc2dbf9
Remove special handling of rustls "buffer full" errors
im-0 May 19, 2026
023c754
Replace own TlsConnection with rustls::Connection
im-0 May 19, 2026
e99f0c4
Fix waiting on a socket
im-0 May 19, 2026
e9e359c
Remove dead code from rustls glue
im-0 May 20, 2026
7a10b53
Do not present rustls errors as OSError(0, "Success")
im-0 May 21, 2026
86ec36b
Remove infinite loop "detection" from rustls glue
im-0 May 21, 2026
fbe1f80
Add test for 1-byte max recv in TLS client
im-0 May 21, 2026
6905963
Add regression test for https://github.com/RustPython/RustPython/issu…
im-0 May 21, 2026
6c0e292
Fix constants in rustls glue code
im-0 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not present rustls errors as OSError(0, "Success")
  • Loading branch information
@im-0
im-0 committed May 21, 2026
commit 7a10b53ba0369d56ef0adebc8b530929079e6937
10 changes: 10 additions & 0 deletions crates/stdlib/src/ssl/compat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,16 @@ impl SslError {
// Use the proper cert verification error creator
create_ssl_cert_verification_error(vm, &cert_err).expect("unlikely to happen")
}
Self::Io(err) if err.kind() == std::io::ErrorKind::UnexpectedEof => {
create_ssl_eof_error(vm).upcast()
}
Self::Io(err) if err.raw_os_error().is_none() => vm
.new_os_subtype_error(
PySSLError::class(&vm.ctx).to_owned(),
None,
format!("SSL error: {err}"),
)
.upcast(),
Self::Io(err) => err.into_pyexception(vm),
Self::SniCallbackRestart => {
// This should be handled at PySSLSocket level
Expand Down