Repository navigation
[META] AI policy #7914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[META] AI policy #7914
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b4e66d1
Add `CONTRIBUTING.md` and link it in the readme
ShaharNaveh 1ab9206
Add TBD PR template
ShaharNaveh 96a895c
Merge remote-tracking branch 'upstream/main' into ai-policy
ShaharNaveh 0daf0f7
Merge `DEVELOPMENT.md` -> `CONTRIBUTING.md`
ShaharNaveh 5c51bfd
Revise `PULL_REQUEST_TEMPLATE.md`
ShaharNaveh df31b9d
Have checkboxes
ShaharNaveh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add TBD PR template
- Loading branch information
commit 1ab920661e2479d5fb6cb23835a2dcf3243af991
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <!-- | ||
| Thanks for your contribution! | ||
|
|
||
| TBD | ||
|
|
||
| --> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure what to write here, any suggestions? @fanninpm @youknowone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could start with these sections:
Closes #WXYZshould suffice, given some criteria [TODO: should be defined] that the linked issue has to meet.)cargo whateverwith no errors. (If not, please explain why.)If you have anything to add to the checklist, it is a good idea to use the active voice in a manner similar to how I wrote the previous bullet points.
Separately from this PR, I think it would be a good idea to convert our Issue templates from Markdown into YAML format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I liked that idea a lot. I've looked around in couple of FOSS projects and took what I liked. If you have a checkbox you would like to add/remove, please feel free to say (or even push it straight to my branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into that:)