Skip to content

Add basic capi error support #7787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 17 commits into from
May 13, 2026
Merged

Add basic capi error support #7787

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2562f9d
Add basic capi error support
bschoenmaeckers May 5, 2026
40d97ea
Add missing symbols to make tests compile again
bschoenmaeckers May 5, 2026
6b79cb5
Add `pyerrors` to dictionary
bschoenmaeckers May 5, 2026
71438c6
Return exception in `Py_GetConstantBorrowed`
bschoenmaeckers May 5, 2026
d708bfe
Remove `allow(dead_code)`
bschoenmaeckers May 5, 2026
bbf3656
Fix windows
bschoenmaeckers May 5, 2026
bccd38e
Load stdlib when calling `Py_InitializeEx`
bschoenmaeckers May 5, 2026
9e20cf7
Debug tests
bschoenmaeckers May 5, 2026
268856b
Revert "Load stdlib when calling `Py_InitializeEx`"
bschoenmaeckers May 6, 2026
8432c17
Disable tests on windows for now
bschoenmaeckers May 6, 2026
130321e
Truncate `PyType_GetFlags` to be always 32 bits
bschoenmaeckers May 6, 2026
30ac061
Add test for exception type checking
bschoenmaeckers May 6, 2026
4e4f7df
Remove subclass type flags
bschoenmaeckers May 6, 2026
22985ca
Merge remote-tracking branch 'origin/main' into capi-errors
bschoenmaeckers May 9, 2026
b2c2f69
Use latest pyo3 to make test work on windows
bschoenmaeckers May 9, 2026
d18d259
Revert "Use latest pyo3 to make test work on windows"
bschoenmaeckers May 10, 2026
4e7bcbf
`set_main_interpreter` -> `init_main_interpreter`
bschoenmaeckers May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable tests on windows for now
  • Loading branch information
@bschoenmaeckers
bschoenmaeckers committed May 6, 2026
commit 8432c1783af996b75974303f9f916c76945d51a5
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ jobs:
- name: run c-api tests
working-directory: crates/capi
run: cargo test
if: runner.os != 'Windows' # Requires pyo3 0.29+ on Windows

@youknowone youknowone May 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything wrong about this? we can pick proper pyo3 version for windows

@bschoenmaeckers bschoenmaeckers May 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to work because we were accidentally linking with the system python. This is now solved. But to make the linker happy we need PyO3/pyo3#5866, this will land in PyO3 0.29 which is unreleased as the time of writing. Furthermore the windows linker expect all symbols to be defined we can only enable this at a later stage when we have defined all ABI3 symbols, see https://github.com/RustPython/RustPython/actions/runs/25607984643/job/75173077533


Comment thread
coderabbitai[bot] marked this conversation as resolved.
- run: cargo doc --locked
if: runner.os == 'Linux'
Expand Down
Loading