Skip to content

Warn on unreachable_pub #7762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 15 commits into from
May 4, 2026
Merged

Warn on unreachable_pub #7762

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7df03f4
Warn on `unreachable_pub`
ShaharNaveh May 2, 2026
700903d
Fix all warnings
ShaharNaveh May 2, 2026
c8cebdd
cargo fmt
ShaharNaveh May 2, 2026
332ab91
fix
ShaharNaveh May 2, 2026
1d1c591
Fix trailing whitespace
ShaharNaveh May 2, 2026
1e4fcb2
fix jit
ShaharNaveh May 2, 2026
bb0f00a
Fix jit tests
ShaharNaveh May 2, 2026
0d2edaf
fix more
ShaharNaveh May 2, 2026
10e7d9d
`crt_fd.rs`
ShaharNaveh May 2, 2026
ef3edf4
typo
ShaharNaveh May 2, 2026
39b6d36
fix wasm
ShaharNaveh May 2, 2026
cae9751
more
ShaharNaveh May 2, 2026
1bf4f27
more
ShaharNaveh May 2, 2026
1315284
Clippy keep going after first error
ShaharNaveh May 2, 2026
a6693bc
more
ShaharNaveh May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix jit tests
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed May 2, 2026
commit bb0f00ad59fe7f6b558cb97f1709f5f3f2a69c65
12 changes: 6 additions & 6 deletions crates/jit/tests/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@ use rustpython_wtf8::{Wtf8, Wtf8Buf};
use std::collections::HashMap;

#[derive(Debug, Clone)]
pub struct Function {
pub(crate) struct Function {
code: Box<CodeObject>,
annotations: HashMap<Wtf8Buf, StackValue>,
}

impl Function {
pub fn compile(self) -> CompiledCode {
pub(crate) fn compile(self) -> CompiledCode {
let mut arg_types = Vec::new();
for arg in self.code.arg_names().args {
let arg_type = match self.annotations.get(AsRef::<Wtf8>::as_ref(arg.as_str())) {
Expand Down Expand Up @@ -171,20 +171,20 @@ fn extract_annotations_from_annotate_code(code: &CodeObject) -> HashMap<Wtf8Buf,
annotations
}

pub struct StackMachine {
pub(crate) struct StackMachine {
stack: Vec<StackValue>,
locals: HashMap<String, StackValue>,
}

impl StackMachine {
pub fn new() -> StackMachine {
pub(crate) fn new() -> StackMachine {
StackMachine {
stack: Vec::new(),
locals: HashMap::new(),
}
}

pub fn run(&mut self, code: CodeObject) {
pub(crate) fn run(&mut self, code: CodeObject) {
let mut op_arg_state = OpArgState::default();
let _ = code.instructions.iter().try_for_each(|&word| {
let (instruction, arg) = op_arg_state.get(word);
Expand Down Expand Up @@ -299,7 +299,7 @@ impl StackMachine {
ControlFlow::Continue(())
}

pub fn get_function(&self, name: &str) -> Function {
pub(crate) fn get_function(&self, name: &str) -> Function {
if let Some(StackValue::Function(function)) = self.locals.get(name) {
function.clone()
} else {
Expand Down
Loading