Repository navigation
Unmask test_strftime_special and test_zones in datetimetester - #7671
Conversation
All three @unittest.skip("TODO: RUSTPYTHON") markers in
datetimetester.py are stale — the tests pass as written on current
main. Probed every assertion in each test body against both CPython
3.13.4 and RustPython: outputs are byte-identical for all unicode
passthrough cases (emoji, lone surrogates, surrogate pairs, null
bytes) in test_strftime_special and for all 11 FixedOffset
comparisons (utcoffset, tzname, dst, hash equality) in test_zones.
Full test.test_datetime run after unmasking: 1803 tests, 0 failures,
0 unexpected successes, 463 skipped (was 469 — 6 test-class inherited
runs now execute successfully).
Part of the skip-test inventory in RustPython#7611.
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
All three @unittest.skip("TODO: RUSTPYTHON") markers in
datetimetester.py are stale — the tests pass as written on current
main. Probed every assertion in each test body against both CPython
3.13.4 and RustPython: outputs are byte-identical for all unicode
passthrough cases (emoji, lone surrogates, surrogate pairs, null
bytes) in test_strftime_special and for all 11 FixedOffset
comparisons (utcoffset, tzname, dst, hash equality) in test_zones.
Full test.test_datetime run after unmasking: 1803 tests, 0 failures,
0 unexpected successes, 463 skipped (was 469 — 6 test-class inherited
runs now execute successfully).
Part of the skip-test inventory in #7611.
3 participants
All three
@unittest.skip("TODO: RUSTPYTHON")markers inLib/test/datetimetester.pyare stale — the tests pass as written on current main.Verification
Probed every assertion in each test body against both CPython 3.13.4 and RustPython on
upstream/main. Outputs are byte-identical for:test_strftime_special(datetime variant, line 3014) — all unicode passthrough cases: emoji (🐍), lone surrogates, surrogate pairs (🐍), null bytes, and embedded format codes (%c,%B).test_strftime_special(time variant, line 3882) — same unicode passthrough with%I%p%Zand%Xformat codes.test_zones(time FixedOffset, line 4363) — 11 assertions coveringtzinfo,utcoffset(),tzname(),dst(), and hash equality acrossFixedOffset(-300, "EST", 1),FixedOffset(0, "UTC", -2),FixedOffset(60, "MET", 3).Full suite after removal:
deflines is inherited by multiple subclasses in the test hierarchy)Part of the skip-test inventory in #7611.