Skip to content

Remove unused rust impl for formatting dis output #7660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 28 commits into from
May 5, 2026
Merged

Remove unused rust impl for formatting dis output #7660

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2cbbaf1
Remove unused rust impl for formatting dis output
ShaharNaveh Apr 23, 2026
774bdcd
remove `examples/dis.rs`
ShaharNaveh Apr 23, 2026
ad9feb0
Added tests
ShaharNaveh Apr 23, 2026
256252c
Update lock
ShaharNaveh Apr 28, 2026
7e8938d
Try to set snapshot dir
ShaharNaveh Apr 28, 2026
693ab8c
Remove verbose flag
ShaharNaveh Apr 28, 2026
ce8b0c8
Regenerate snapshots after #7711
ShaharNaveh Apr 28, 2026
d9751c9
Revert "Bump insta from 1.46.3 to 1.47.2 (#7706)"
ShaharNaveh Apr 28, 2026
b0ec4a0
Debug info
ShaharNaveh Apr 29, 2026
dc4c857
Show diff as well
ShaharNaveh Apr 29, 2026
bae530c
Show debug faster
ShaharNaveh Apr 29, 2026
7a77e65
CI: true env
ShaharNaveh Apr 29, 2026
58c8d53
Recert CI
ShaharNaveh Apr 29, 2026
a3f690e
Add `CI: true` in ci emv
ShaharNaveh Apr 29, 2026
182b4f5
Reapply "Bump insta from 1.46.3 to 1.47.2 (#7706)"
ShaharNaveh Apr 29, 2026
c235e6c
simplify macro
ShaharNaveh Apr 30, 2026
42353fa
trim on function side
ShaharNaveh Apr 30, 2026
2450d69
Force insta workspace root
ShaharNaveh May 1, 2026
b5326b3
Merge remote-tracking branch 'upstream/main' into remove-fmt-dis
ShaharNaveh May 1, 2026
e4f7ea0
Merge remote-tracking branch 'upstream/main' into remove-fmt-dis
ShaharNaveh May 2, 2026
89a4da6
Merge remote-tracking branch 'upstream/main' into remove-fmt-dis
ShaharNaveh May 2, 2026
8f3d793
Merge remote-tracking branch 'upstream/main' into remove-fmt-dis
ShaharNaveh May 4, 2026
1cc518f
Merge remote-tracking branch 'upstream/main' into remove-fmt-dis
ShaharNaveh May 4, 2026
ad2b24f
fix merge
ShaharNaveh May 4, 2026
fd5d487
Merge remote-tracking branch 'upstream/main' into remove-fmt-dis
ShaharNaveh May 5, 2026
5c3aa0d
fixing bad merge
ShaharNaveh May 5, 2026
15d212f
regen snapshot
ShaharNaveh May 5, 2026
5806655
Merge remote-tracking branch 'upstream/main' into remove-fmt-dis
ShaharNaveh May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add CI: true in ci emv
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed May 1, 2026
commit a3f690ec750e2f4aa8ebcc115f3101507b0c050f
3 changes: 2 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ env:
CARGO_PROFILE_RELEASE_DEBUG: 0
CARGO_TERM_COLOR: always
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true # TODO: Remove on 2026/06/02
CI: true

jobs:
rust_tests:
Expand Down Expand Up @@ -77,7 +78,7 @@ jobs:
run: cargo clippy ${{ env.CARGO_ARGS }} --workspace --all-targets ${{ env.WORKSPACE_EXCLUDES }} -- -Dwarnings

- name: run rust tests
run: cargo test --workspace ${{ env.WORKSPACE_EXCLUDES }} --verbose --features threading ${{ env.CARGO_ARGS }}
run: cargo test --workspace ${{ env.WORKSPACE_EXCLUDES }} --features threading ${{ env.CARGO_ARGS }}

@fanninpm fanninpm Apr 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: cargo test --workspace ${{ env.WORKSPACE_EXCLUDES }} --features threading ${{ env.CARGO_ARGS }}
run: cargo test --workspace ${{ env.WORKSPACE_EXCLUDES }} --features threading ${{ env.CARGO_ARGS }}
env:
CI: true

What about here?

@ShaharNaveh ShaharNaveh Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think there's a value to putting it at the top. other tools in the future (or even exiting ones) might look at this value, it because a standard from what I can tell. but it's not a hill I'm willing to die on


- name: check compilation without threading
run: cargo check ${{ env.CARGO_ARGS }}
Expand Down