Add minimal C-api implementation that builds with Pyo3 - #7562
bschoenmaeckers wants to merge 211 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Could you try with hpy if you dont mind? We are looking for sustainable way |
That would require significant changes in codebase that are using the CPython api spec. I would like to explore the possibility to use the ab3/abi3t api. Would you be willing to accept that? |
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
This way will not work.
Just in case, the code can be generated, but I hope we carefully review the decisions. unlikely-to-happen decisions must be reviewed and justified by document(comment) the decisions.
If you are not familiar enough to the project to decide good way, please start from a smaller and simpler issue.
We only need abi3t, because we are compatible to free-threading.
We have to minimize the surface of C API. if HPy helps it, we need HPy.
Ideally c api must be very thin wrappers to RustPython features. "code" must not be included in this crate.
I wanted to create as little of modificaties to the existing code base without significant motivation. But I definitely agree with you. |
c0d904e to
4b642b2
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
4 participants
This is my shot at implementing a minimal Cpython compatible C-api. I've implemented the bare minimum to get the included Pyo3 example running where most of the api is stubbed. I'm not familiar with the rest of the RustPython code base so let me know what you think and where I did stupid things.
Please take extra care reviewing the pylifecycle.rs & pystate.rs files where I try to setup the RustPython interpreter.
xref #5604