Skip to content

gc: add CollectResult, stats fields, get_referrers, and fix count reset #7354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 10 commits into from
Mar 12, 2026
Merged

gc: add CollectResult, stats fields, get_referrers, and fix count reset #7354

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d4d329f
gc: add CollectResult, stats fields, get_referrers, and fix count reset
youknowone Mar 5, 2026
c889a96
Update test_gc from v3.14.3
Mar 5, 2026
a34d701
Update test_gc.py from CPython v3.15.0a5
youknowone Mar 5, 2026
463eb1d
Fix gc_state build on wasm32: skip Instant timing
youknowone Mar 5, 2026
dfee990
Add candidates/duration to gc callback info, mark v3.15 test failures
youknowone Mar 5, 2026
2547ef8
Fix gc.get_referrers to exclude executing frames, fix Future cancelle…
youknowone Mar 6, 2026
980c731
Fix gc.get_threshold to return actual gen2 threshold value
youknowone Mar 9, 2026
f1d0b44
Fix inconsistent GC count reset in early-return paths
youknowone Mar 9, 2026
2282a51
Accept keyword arguments in socket.__init__
youknowone Mar 9, 2026
d62481f
Disable comp_inlined in symbol table to match compiler
youknowone Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Accept keyword arguments in socket.__init__ 
Use a FromArgs struct instead of a positional-only tuple so that
family, type, proto, and fileno can be passed as keyword arguments.
  • Loading branch information
@youknowone
youknowone committed Mar 10, 2026
commit 2282a515d65d993758238219b7910e631fea1d89
28 changes: 18 additions & 10 deletions crates/stdlib/src/socket.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,13 +1384,20 @@ mod _socket {

impl DefaultConstructor for PySocket {}

#[derive(FromArgs)]
pub struct SocketInitArgs {
#[pyarg(any, optional)]
family: OptionalArg<i32>,
#[pyarg(any, optional)]
r#type: OptionalArg<i32>,
#[pyarg(any, optional)]
proto: OptionalArg<i32>,
#[pyarg(any, optional)]
fileno: OptionalOption<PyObjectRef>,
}

impl Initializer for PySocket {
type Args = (
OptionalArg<i32>,
OptionalArg<i32>,
OptionalArg<i32>,
OptionalOption<PyObjectRef>,
);
type Args = SocketInitArgs;

fn init(zelf: PyRef<Self>, args: Self::Args, vm: &VirtualMachine) -> PyResult<()> {
Self::_init(zelf, args, vm).map_err(|e| e.into_pyexception(vm))
Expand All @@ -1414,13 +1421,14 @@ mod _socket {
impl PySocket {
fn _init(
zelf: PyRef<Self>,
(family, socket_kind, proto, fileno): <Self as Initializer>::Args,
args: <Self as Initializer>::Args,
vm: &VirtualMachine,
) -> Result<(), IoOrPyException> {
let mut family = family.unwrap_or(-1);
let mut socket_kind = socket_kind.unwrap_or(-1);
let mut proto = proto.unwrap_or(-1);
let mut family = args.family.unwrap_or(-1);
let mut socket_kind = args.r#type.unwrap_or(-1);
let mut proto = args.proto.unwrap_or(-1);

let fileno = args.fileno;
let sock;

// On Windows, fileno can be bytes from socket.share() for fromshare()
Expand Down