Skip to content

Specialized ops #7322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 12 commits into from
Mar 4, 2026
Merged

Specialized ops #7322

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e77bb5a
Add CALL_ALLOC_AND_ENTER_INIT specialization
youknowone Mar 2, 2026
4ab342d
Invalidate JIT cache when __code__ is reassigned
youknowone Mar 3, 2026
5e9ec26
Atomic operations for specialization cache
youknowone Mar 3, 2026
c9a40ce
Fix slot wrapper override for inherited attributes
youknowone Mar 3, 2026
2bd0d10
Fix StoreAttrSlot cache overflow corrupting next instruction
youknowone Mar 3, 2026
7bd5300
Exclude method_descriptor from has_python_cmp check
youknowone Mar 3, 2026
5c81306
Fix CompareOpFloat NaN handling
youknowone Mar 3, 2026
5a1b29b
Fix invoke_exact_args borrow in CallAllocAndEnterInit
youknowone Mar 3, 2026
f99e95f
Distinguish Python method vs not-found in slot MRO lookup
youknowone Mar 3, 2026
8821456
Extract specialization helper functions to reduce boilerplate
youknowone Mar 3, 2026
dd89151
Improve specialization guards and fix mark_stacks
youknowone Mar 3, 2026
21c29ca
Auto-format: cargo fmt --all
github-actions[bot] Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix CompareOpFloat NaN handling 
partial_cmp returns None for NaN comparisons. is_some_and incorrectly
returned false for all NaN comparisons, but NaN != x should be true
per IEEE 754 semantics.
  • Loading branch information
@youknowone
youknowone committed Mar 4, 2026
commit 5c81306fa4b11ef634ce63d80029a92fcd769b82
10 changes: 6 additions & 4 deletions crates/vm/src/frame.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4584,10 +4584,12 @@ impl ExecutingFrame<'_> {
b.downcast_ref_if_exact::<PyFloat>(vm),
) {
let op = self.compare_op_from_arg(arg);
let result = a_f
.to_f64()
.partial_cmp(&b_f.to_f64())
.is_some_and(|ord| op.eval_ord(ord));
let (a, b) = (a_f.to_f64(), b_f.to_f64());
// Use Rust's IEEE 754 float comparison which handles NaN correctly
let result = match a.partial_cmp(&b) {
Some(ord) => op.eval_ord(ord),
None => op == PyComparisonOp::Ne, // NaN != anything is true
};
self.pop_value();
self.pop_value();
self.push_value(vm.ctx.new_bool(result).into());
Expand Down