Repository navigation
Ensure no warnings on various targets - #7245
Draft
ShaharNaveh wants to merge 12 commits into
Draft
ShaharNaveh wants to merge 12 commits into
ShaharNaveh wants to merge 12 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
youknowone
approved these changes
Feb 27, 2026
Contributor
|
Code has been automatically formatted The code in this PR has been formatted using:
git pull origin disallow-warnings |
ShaharNaveh
commented
Feb 27, 2026
| #[pyarg(positional, default)] | ||
| #[pystruct_sequence(unnamed)] | ||
| pub st_mtime_int: libc::time_t, | ||
| #[cfg_attr(target_env = "musl", allow(deprecated))] |
Contributor
Author
There was a problem hiding this comment.
No matter what I do, the deprecation warning still shows. @youknowone I believe we have a bug related to #[cfg_attr(...)] with #[pystruct_sequence(...)] (and possibly related to when used with #[pyarg(...)])
youknowone
force-pushed
the
disallow-warnings
branch
from
September 16, 2026 17:18
6f597bd to
1abca20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ATM build on android yield an "unused import" warning. This PR aims to make sure warnings like this don't appear from time to time