Skip to content

Implement Windows SemLock in _multiprocessing module #7199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 7 commits into from
Feb 24, 2026
Merged

Implement Windows SemLock in _multiprocessing module #7199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e88eaf0
Implement Windows SemLock in _multiprocessing module
youknowone Feb 17, 2026
2903370
Fix _multiprocessing recv to return bytes and improve SemLock reliabi…
youknowone Feb 22, 2026
4dd6042
Include winerror in OSError.__reduce__ on Windows
youknowone Feb 22, 2026
c40092b
Remove expectedFailure for tests now passing with Windows SemLock
youknowone Feb 22, 2026
9649be1
Fix OSError.__reduce__ to preserve winerror when filename is None
youknowone Feb 22, 2026
c7d65b9
Validate maxvalue > 0 in SemLock and document winerror __reduce__ div…
youknowone Feb 23, 2026
7b8bce4
Reject embedded null characters in mmap tagname and _winapi file mapp…
youknowone Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Validate maxvalue > 0 in SemLock and document winerror __reduce__ div… 
…ergence
  • Loading branch information
@youknowone
youknowone committed Feb 23, 2026
commit c7d65b9a5ba9e3bef69fe47ba2c8008fc1203fff
3 changes: 3 additions & 0 deletions crates/stdlib/src/multiprocessing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,9 @@ mod _multiprocessing {
if args.kind != RECURSIVE_MUTEX && args.kind != SEMAPHORE {
return Err(vm.new_value_error("unrecognized kind".to_owned()));
}
if args.maxvalue <= 0 {
return Err(vm.new_value_error("maxvalue must be positive".to_owned()));
}
if args.value < 0 || args.value > args.maxvalue {
return Err(vm.new_value_error("invalid value".to_owned()));
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Expand Down
2 changes: 2 additions & 0 deletions crates/vm/src/exceptions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2077,6 +2077,8 @@ pub(super) mod types {
args_reduced.push(vm.ctx.none());
args_reduced.push(filename2);
} else {
// Diverges from CPython: include winerror even without
// filename2 so it survives pickle round-trips.
#[cfg(windows)]
if let Some(winerror) = winerror {
args_reduced.push(winerror);
Expand Down
Loading