Skip to content

Pseudo ops #6678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
Jan 10, 2026
Merged

Pseudo ops #6678

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
725f12d
better expect
youknowone Jan 9, 2026
ea8f8d1
pseudo instruction
youknowone Jan 8, 2026
68a8060
Fix CallKw narg
youknowone Jan 10, 2026
ce93c4f
Auto-format: cargo fmt --all
github-actions[bot] Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
better expect
  • Loading branch information
@youknowone
youknowone committed Jan 10, 2026
commit 725f12d48a0315aa67ff496ecf54ca8608afc1c2
17 changes: 9 additions & 8 deletions crates/codegen/src/compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6212,16 +6212,17 @@ impl Compiler {
}
emit!(self, Instruction::CallFunctionEx { has_kwargs });
} else if !arguments.keywords.is_empty() {
// No **kwargs in this branch (has_double_star is false),
// so all keywords have arg.is_some()
let mut kwarg_names = vec![];
for keyword in &arguments.keywords {
if let Some(name) = &keyword.arg {
kwarg_names.push(ConstantData::Str {
value: name.as_str().into(),
});
} else {
// This means **kwargs!
panic!("name must be set");
}
let name = keyword
.arg
.as_ref()
.expect("has_double_star is false, so arg must be Some");
kwarg_names.push(ConstantData::Str {
value: name.as_str().into(),
});
self.compile_expression(&keyword.value)?;
}

Expand Down