Skip to content

Make use of Unary opcodes #6647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 10 commits into from
Jan 5, 2026
Merged

Make use of Unary opcodes #6647

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eece3bf
Make use of `Unary` opcodes
ShaharNaveh Jan 4, 2026
fd3ef1d
Fix jit
ShaharNaveh Jan 5, 2026
c54b881
Merge remote-tracking branch 'upstream/main' into bytecode-split-unary
ShaharNaveh Jan 5, 2026
15d9e0a
Add `Reserved140` opcode
ShaharNaveh Jan 5, 2026
5641bc9
re-add support for UnaryPositive in JIT
ShaharNaveh Jan 5, 2026
cf8cf21
resolve arg
ShaharNaveh Jan 5, 2026
f12d2f3
Use correct instruction
ShaharNaveh Jan 5, 2026
50763ce
JIT support for `ToBool` instruction
ShaharNaveh Jan 5, 2026
0696124
Fix unarynot
ShaharNaveh Jan 5, 2026
f86f0d5
Merge remote-tracking branch 'upstream/main' into bytecode-split-unary
ShaharNaveh Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unarynot
  • Loading branch information
@ShaharNaveh
ShaharNaveh committed Jan 5, 2026
commit 0696124edf140b0f926151241e6e13230ebb4839
5 changes: 4 additions & 1 deletion crates/jit/src/instructions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,7 +642,10 @@ impl<'a, 'b> FunctionCompiler<'a, 'b> {
Ok(())
}
Instruction::UnaryNot => {
let boolean = self.stack.pop().ok_or(JitCompileError::BadBytecode)?;
let boolean = match self.stack.pop().ok_or(JitCompileError::BadBytecode)? {
JitValue::Bool(val) => val,
_ => return Err(JitCompileError::BadBytecode),
};
let not_boolean = self.builder.ins().bxor_imm(boolean, 1);
self.stack.push(JitValue::Bool(not_boolean));
Ok(())
Expand Down
Loading