Skip to content

Updated tempfile libraries + associated tests - V3.13.11 #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Jan 4, 2026
Merged

Updated tempfile libraries + associated tests - V3.13.11 #6632

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f40b4a6
Updated subprocess library test
terryluan12 Jan 3, 2026
3490742
Updated tempfile library + test
terryluan12 Jan 3, 2026
ff296fb
Skipped the test_cleanup_with_symlink_modes test
terryluan12 Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updated subprocess library test
  • Loading branch information
@terryluan12 @youknowone
terryluan12 authored and youknowone committed Jan 4, 2026
commit f40b4a67d65c14b5e80c0a31dff54420d21f8938
24 changes: 9 additions & 15 deletions Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,8 +800,7 @@ def test_env(self):
stdout, stderr = p.communicate()
self.assertEqual(stdout, b"orange")

# TODO: RUSTPYTHON
@unittest.expectedFailure
@unittest.expectedFailure # TODO: RUSTPYTHON
@unittest.skipUnless(sys.platform == "win32", "Windows only issue")
def test_win32_duplicate_envs(self):
newenv = os.environ.copy()
Expand Down Expand Up @@ -1292,8 +1291,7 @@ def test_universal_newlines_communicate_stdin_stdout_stderr(self):
# to stderr at exit of subprocess.
self.assertTrue(stderr.startswith("eline2\neline6\neline7\n"))

# TODO: RUSTPYTHON
@unittest.expectedFailure
@unittest.expectedFailure # TODO: RUSTPYTHON
def test_universal_newlines_communicate_encodings(self):
# Check that universal newlines mode works for various encodings,
# in particular for encodings in the UTF-16 and UTF-32 families.
Expand Down Expand Up @@ -2276,16 +2274,14 @@ def test_group_error(self):
with self.assertRaises(ValueError):
subprocess.check_call(ZERO_RETURN_CMD, group=65535)

# TODO: RUSTPYTHON, observed gids do not match expected gids
@unittest.expectedFailure
@unittest.expectedFailure # TODO: RUSTPYTHON; observed gids do not match expected gids
@unittest.skipUnless(hasattr(os, 'setgroups'), 'no setgroups() on platform')
def test_extra_groups(self):
gid = os.getegid()
group_list = [65534 if gid != 65534 else 65533]
self._test_extra_groups_impl(gid=gid, group_list=group_list)

# TODO: RUSTPYTHON
@unittest.expectedFailure
@unittest.expectedFailure # TODO: RUSTPYTHON
@unittest.skipUnless(hasattr(os, 'setgroups'), 'no setgroups() on platform')
def test_extra_groups_empty_list(self):
self._test_extra_groups_impl(gid=os.getegid(), group_list=[])
Expand Down Expand Up @@ -2321,8 +2317,8 @@ def _test_extra_groups_impl(self, *, gid, group_list):
subprocess.check_call(ZERO_RETURN_CMD,
extra_groups=[name_group])

@unittest.skip("TODO: RUSTPYTHON; clarify failure condition")
# No skip necessary, this test won't make it to a setgroup() call.
@unittest.skip('TODO: RUSTPYTHON; clarify failure condition')
def test_extra_groups_invalid_gid_t_values(self):
with self.assertRaises(ValueError):
subprocess.check_call(ZERO_RETURN_CMD, extra_groups=[-1])
Expand Down Expand Up @@ -2449,8 +2445,7 @@ def raise_it():
stdin=subprocess.PIPE, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, preexec_fn=raise_it)

# TODO: RUSTPYTHON
@unittest.expectedFailure
@unittest.expectedFailure # TODO: RUSTPYTHON
def test_preexec_gc_module_failure(self):
# This tests the code that disables garbage collection if the child
# process will execute any Python.
Expand Down Expand Up @@ -3021,7 +3016,7 @@ def kill_p2():
p1.stdout.close()
p2.stdout.close()

@unittest.skip("TODO: RUSTPYTHON, flaky test")
@unittest.skip('TODO: RUSTPYTHON; flaky test')
def test_close_fds(self):
fd_status = support.findfile("fd_status.py", subdir="subprocessdata")

Expand Down Expand Up @@ -3149,11 +3144,11 @@ def test_close_fds_when_max_fd_is_lowered(self):
msg="Some fds were left open.")


@unittest.skip("TODO: RUSTPYTHON, flaky test")
# Mac OS X Tiger (10.4) has a kernel bug: sometimes, the file
# descriptor of a pipe closed in the parent process is valid in the
# child process according to fstat(), but the mode of the file
# descriptor is invalid, and read or write raise an error.
@unittest.skip('TODO: RUSTPYTHON; flaky test')
@support.requires_mac_ver(10, 5)
def test_pass_fds(self):
fd_status = support.findfile("fd_status.py", subdir="subprocessdata")
Expand Down Expand Up @@ -3566,8 +3561,7 @@ def test_communicate_repeated_call_after_stdout_close(self):
except subprocess.TimeoutExpired:
pass

# TODO: RUSTPYTHON
@unittest.expectedFailure
@unittest.expectedFailure # TODO: RUSTPYTHON
def test_preexec_at_exit(self):
code = f"""if 1:
import atexit
Expand Down