Skip to content

Update pty + tty + associated libraries - v3.13.10 #6630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 9 commits into from
Jan 5, 2026
Merged

Update pty + tty + associated libraries - v3.13.10 #6630

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4f1c2f0
Update tty + added the test from v3.13.10
terryluan12 Jan 3, 2026
0cee63f
Added annotations for skipped tty tests
terryluan12 Jan 3, 2026
f402652
Updated pty.py + test
terryluan12 Jan 3, 2026
66d4d69
Fixed test_tty
terryluan12 Jan 3, 2026
82e57be
Merge branch 'base_main' into update_pty_tty
terryluan12 Jan 4, 2026
59c7ab3
Changed skips to expectedFailures in `test_tty.py`
terryluan12 Jan 5, 2026
3a52087
Annotated failing/erroring tests
terryluan12 Jan 5, 2026
f90dac4
Update Lib/test/test_pty.py
youknowone Jan 5, 2026
02d6d0f
Update Lib/test/test_pty.py
youknowone Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Annotated failing/erroring tests
  • Loading branch information
@terryluan12
terryluan12 committed Jan 5, 2026
commit 3a520871400ab1710a326731afee9449fd1e8391
4 changes: 4 additions & 0 deletions Lib/test/test_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2241,6 +2241,7 @@ def child(wpipe):
expected = terminal_input.decode(sys.stdin.encoding) # what else?
self.assertEqual(input_result, expected)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_input_tty(self):
# Test input() functionality when wired to a tty (the code path
# is different and invokes GNU readline if available).
Expand All @@ -2257,17 +2258,20 @@ def skip_if_readline(self):
self.skipTest("the readline module is loaded")

@unittest.skipUnless(hasattr(sys.stdin, 'detach'), 'TODO: RustPython: requires detach function in TextIOWrapper')
@unittest.expectedFailure # TODO: RUSTPYTHON AssertionError: got 0 lines in pipe but expected 2, child output was: quux
def test_input_tty_non_ascii(self):
self.skip_if_readline()
# Check stdin/stdout encoding is used when invoking PyOS_Readline()
self.check_input_tty("prompté", b"quux\xe9", "utf-8")

@unittest.skipUnless(hasattr(sys.stdin, 'detach'), 'TODO: RustPython: requires detach function in TextIOWrapper')
@unittest.expectedFailure # TODO: RUSTPYTHON AssertionError: got 0 lines in pipe but expected 2, child output was: quux
def test_input_tty_non_ascii_unicode_errors(self):
self.skip_if_readline()
# Check stdin/stdout error handler is used when invoking PyOS_Readline()
self.check_input_tty("prompté", b"quux\xe9", "ascii")

@unittest.expectedFailure # TODO: RUSTPYTHON AssertionError: got 0 lines in pipe but expected 2, child output was: quux
def test_input_no_stdout_fileno(self):
# Issue #24402: If stdin is the original terminal but stdout.fileno()
# fails, do not use the original stdout file descriptor
Expand Down
Loading