Skip to content

Replace SSL backend to rustls #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 4 commits into from
Nov 16, 2025
Merged

Replace SSL backend to rustls #6244

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b062944
Create a new ssl library based on rustls
youknowone Nov 9, 2025
7ef298c
ring -> aws-ls
youknowone Nov 11, 2025
8ccba94
Add warnings
youknowone Nov 10, 2025
98fb4ad
version
youknowone Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
version
  • Loading branch information
@youknowone
youknowone committed Nov 15, 2025
commit 98fb4ada5ade0ebd1d361327ffd44e98f59298e2
4 changes: 2 additions & 2 deletions stdlib/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,12 @@ rustls = { version = "0.23.35", default-features = false, features = ["std", "tl
rustls-native-certs = { version = "0.8", optional = true }
rustls-pemfile = { version = "2.2", optional = true }
rustls-platform-verifier = { version = "0.6", optional = true }
x509-cert = { version = "0.2", features = ["pem", "builder"], optional = true }
x509-cert = { version = "0.2.5", features = ["pem", "builder"], optional = true }
x509-parser = { version = "0.16", optional = true }
der = { version = "0.7", features = ["alloc", "oid"], optional = true }
pem-rfc7468 = { version = "0.7", optional = true }
webpki-roots = { version = "0.26", optional = true }
aws-lc-rs = { version = "1.10", optional = true }
aws-lc-rs = { version = "1.14.1", optional = true }
oid-registry = { version = "0.7", features = ["x509", "pkcs1", "nist_algs"], optional = true }
pkcs8 = { version = "0.10", features = ["encryption", "pkcs5", "pem"], optional = true }
Comment on lines +116 to +134

@coderabbitai coderabbitai Bot Nov 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify crypto/TLS dependency versions remain current (8 months post knowledge cutoff).

The dependency versions were corrected in response to prior review feedback (x509-cert → 0.2.5, aws-lc-rs → 1.14.1), but with knowledge cutoff at March 2025 and current date November 2025, verify these are still the recommended stable versions:

  • rustls = 0.23.35
  • x509-cert = 0.2.5
  • aws-lc-rs = 1.14.1
  • openssl = 0.10.72

🌐 Web query:

What are the latest stable versions of rustls, x509-cert, aws-lc-rs, and openssl crates as of November 2025?

💡 Result:

As of November 15, 2025:

  • rustls — 0.23.28. [1]
  • x509-cert — 0.2.5. [2]
  • aws-lc-rs — 1.14.1. [3]
  • openssl (crate) — 0.10.72. [4]

Sources:
[1] rustls crate listing (lib.rs).
[2] rust-x509-cert package / crates listing (Fedora packages).
[3] aws-lc-rs docs/crate page (docs.rs).
[4] openssl crate update notices (crates.io / Fedora security advisory).

Downgrade rustls to 0.23.28 (current latest stable, not 0.23.35).

The latest stable version of rustls as of November 15, 2025 is 0.23.28, but line 127 declares 0.23.35. The other dependencies are correctly specified: x509-cert 0.2.5, aws-lc-rs 1.14.1, and openssl 0.10.72 are current.

Line 127:

- rustls = { version = "0.23.28", default-features = false, features = ["std", "tls12", "aws_lc_rs"], optional = true }
🤖 Prompt for AI Agents 
In stdlib/Cargo.toml around lines 116 to 134, the rustls dependency is pinned to
version "0.23.35" but should be downgraded to "0.23.28"; update the rustls line
to use version = "0.23.28" (keeping default-features, features and optional
flags unchanged) so the Cargo.toml matches the current stable rustls version.


Comment thread
coderabbitai[bot] marked this conversation as resolved.
Expand Down
Loading