Skip to content

Implement PyComplex's __format__ function #5900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 8 commits into from
Jul 4, 2025
Merged

Implement PyComplex's __format__ function #5900

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
65dbae3
Add num-complex in rustpython-common
yt2b Jul 3, 2025
9843aec
Implement PyComplex's __format__ function
yt2b Jul 3, 2025
fa93d55
Remove @unittest.expectedFailure
yt2b Jul 3, 2025
33d9b17
Fix PyComplex's __format__ function
yt2b Jul 4, 2025
4c12e08
Remove @unittest.expectedFailure
yt2b Jul 4, 2025
fc47ac8
Add extra tests
yt2b Jul 4, 2025
ecc7ae4
Merge branch 'main' into complex_format
yt2b Jul 4, 2025
010797e
Rename to ZeroPadding and AlignmentFlag
yt2b Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into complex_format
  • Loading branch information
@yt2b
yt2b committed Jul 4, 2025
commit ecc7ae4434fa6fbc463be5f0527c0906a1cc8505
14 changes: 5 additions & 9 deletions vm/src/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,15 @@ impl IntoPyException for FormatSpecError {
let msg = format!("{s} not allowed with integer format specifier 'c'");
vm.new_value_error(msg)
}
FormatSpecError::UnableToConvert => {
vm.new_value_error("Unable to convert int to float")
}
FormatSpecError::CodeNotInRange => {
vm.new_overflow_error("%c arg not in range(0x110000)")
}
FormatSpecError::ZeroPaddingNotAllowed => {
Self::UnableToConvert => vm.new_value_error("Unable to convert int to float"),
Self::CodeNotInRange => vm.new_overflow_error("%c arg not in range(0x110000)"),
Self::ZeroPaddingNotAllowed => {
vm.new_value_error("Zero padding is not allowed in complex format specifier")
}
FormatSpecError::AlignmentFlagNotAllowed => {
Self::AlignmentFlagNotAllowed => {
vm.new_value_error("'=' alignment flag is not allowed in complex format specifier")
}
FormatSpecError::NotImplemented(c, s) => {
Self::NotImplemented(c, s) => {
let msg = format!("Format code '{c}' for object of type '{s}' not implemented yet");
vm.new_value_error(msg)
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.