Skip to content

Rework issubclass #5867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 5 commits into from
Jun 29, 2025
Merged

Rework issubclass #5867

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8abf2da
check_exact
youknowone Jun 28, 2025
7a92989
check_class
youknowone Jun 28, 2025
241a8f1
Type compatibility tools
youknowone Jun 28, 2025
6e08225
abstract_issubclass
youknowone Jun 29, 2025
4e5007a
recursive_issubclass
youknowone Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
check_exact
  • Loading branch information
@youknowone
youknowone committed Jun 29, 2025
commit 8abf2daf4ec41861824b53f6cf0db6671ec76adc
6 changes: 6 additions & 0 deletions vm/src/builtins/type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,12 @@ impl PyType {
}

impl Py<PyType> {
/// Equivalent to CPython's PyType_CheckExact macro
/// Checks if obj is exactly a type (not a subclass)
pub fn check_exact<'a>(obj: &'a PyObject, vm: &VirtualMachine) -> Option<&'a Py<PyType>> {
obj.downcast_ref_if_exact::<PyType>(vm)
}

/// Determines if `subclass` is actually a subclass of `cls`, this doesn't call __subclasscheck__,
/// so only use this if `cls` is known to have not overridden the base __subclasscheck__ magic
/// method.
Expand Down