Repository navigation
Fix encodings related error messages to be less confusing - #5049
Merged
Merged
Conversation
fanninpm
reviewed
Aug 27, 2023
fanninpm
left a comment
fanninpm
left a comment
Contributor
There was a problem hiding this comment.
A few nitpicks to help with grammar/clarity.
youknowone
marked this pull request as draft
August 28, 2023 05:39
youknowone
marked this pull request as ready for review
August 29, 2023 11:26
Member
Author
|
@fanninpm Thank you! Is this now looking good? |
youknowone
commented
Aug 29, 2023
Co-authored-by: fanninpm <fanninpm@miamioh.edu>
youknowone
force-pushed
the
import-encodings
branch
from
August 30, 2023 10:46
cbd82b6 to
3fa8773
Compare
Co-authored-by: fanninpm <fanninpm@miamioh.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import encodingswhenSettings::path_listis empty.is now part ofrustpythoncrate. Users can skip it when they don't want to add cwd to path_list when they create their own interpreter.cc @dannasman