Skip to content

Return SyntaxError with null byte input in eval. #5013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DimitrisJim merged 2 commits into from
Jun 17, 2023
Merged

Return SyntaxError with null byte input in eval. #5013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b52834
Return SyntaxError with null byte input in eval.
DimitrisJim Jun 17, 2023
332edf3
Special case MacOS for now, add a note for future sanity.
DimitrisJim Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion extra_tests/snippets/syntax_non_utf8.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@

dir_path = os.path.dirname(os.path.realpath(__file__))

with assert_raises(ValueError):
# TODO: RUSTPYTHON. At some point snippets will fail and it will look confusing
# and out of the blue. This is going to be the cause and it's going to happen when
# the github worker for MacOS starts using Python 3.11.4.
if platform.python_implementation == "CPython" and platform.system() == 'Darwin':
expectedException = ValueError
else:
expectedException = SyntaxError

with assert_raises(expectedException):
with open(os.path.join(dir_path , "non_utf8.txt")) as f:
eval(f.read())
3 changes: 2 additions & 1 deletion vm/src/stdlib/builtins.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,8 @@ mod builtins {
Either::A(either) => {
let source: &[u8] = &either.borrow_bytes();
if source.contains(&0) {
return Err(vm.new_value_error(
return Err(vm.new_exception_msg(
vm.ctx.exceptions.syntax_error.to_owned(),
"source code string cannot contain null bytes".to_owned(),
));
}
Expand Down