Skip to content

Update to pass test for unhashable collections #4640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 11 commits into from
Mar 7, 2023
Merged

Update to pass test for unhashable collections #4640

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eb0f2f3
Update to pass test for unhashable
blue-pandaa Mar 7, 2023
2e12da2
Fix casting error of function pointer
blue-pandaa Mar 5, 2023
92526b5
Generalize unhashable logic using PyClassDef
blue-pandaa Mar 7, 2023
725060c
Use map_or instead of map + unwrap_or
blue-pandaa Mar 7, 2023
5588a63
Compare with ctx.none instead of ctx.none()
blue-pandaa Mar 7, 2023
297179e
Simplify duplicated call of toggle_slot!
blue-pandaa Mar 7, 2023
95fd1e8
Follow CPython's naming for unhashable
blue-pandaa Mar 7, 2023
6d4e7c9
Make PyRef<T>'s UNHASHABLE follow T's
blue-pandaa Mar 7, 2023
e5b338e
Remove unused import
blue-pandaa Mar 7, 2023
07274f3
Remove expectedFailure annotation of passed test
blue-pandaa Mar 7, 2023
ea7c4f0
Update vm/src/builtins/slice.rs
youknowone Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update vm/src/builtins/slice.rs
  • Loading branch information
@youknowone
youknowone authored Mar 7, 2023
commit ea7c4f0e89e3672e46c0fd4edac7e80b96bfcc11
1 change: 0 additions & 1 deletion vm/src/builtins/slice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ impl PyPayload for PySlice {
}
}

// #[pyclass(with(Hashable, Comparable))]
#[pyclass(with(Comparable))]
impl PySlice {
#[pygetset]
Expand Down