Skip to content

Implement Number protocol for PyNone #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 3 commits into from
Jul 16, 2022
Merged

Implement Number protocol for PyNone #3880

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47587d1
Implement Number protocol for PyNone
hy-kiera Jul 14, 2022
bcf6dbd
solve warning of unused variable, 'number'
hy-kiera Jul 15, 2022
f21b8a0
chore: group type traits
hy-kiera Jul 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Implement Number protocol for PyNone
  • Loading branch information
@hy-kiera
hy-kiera committed Jul 15, 2022
commit 47587d1bb4132831ea8f4ad2df5fed0a6eed4060
13 changes: 10 additions & 3 deletions vm/src/builtins/singletons.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use super::{PyType, PyTypeRef};
use crate::{
class::PyClassImpl, convert::ToPyObject, types::Constructor, Context, Py, PyObjectRef,
PyPayload, PyResult, VirtualMachine,
class::PyClassImpl, convert::ToPyObject, protocol::PyNumberMethods, types::AsNumber,
types::Constructor, Context, Py, PyObjectRef, PyPayload, PyResult, VirtualMachine,

@youknowone youknowone Jul 15, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also group type traits

types::{AsNumber, Constructor}

};

#[pyclass(module = false, name = "NoneType")]
Expand Down Expand Up @@ -39,7 +39,7 @@ impl Constructor for PyNone {
}
}

#[pyimpl(with(Constructor))]
#[pyimpl(with(Constructor, AsNumber))]
impl PyNone {
#[pymethod(magic)]
fn repr(&self) -> String {
Expand All @@ -52,6 +52,13 @@ impl PyNone {
}
}

impl AsNumber for PyNone {
const AS_NUMBER: PyNumberMethods = PyNumberMethods {
boolean: Some(|number, _vm| Ok(false)),
..PyNumberMethods::NOT_IMPLEMENTED
};
}

#[pyclass(module = false, name = "NotImplementedType")]
#[derive(Debug)]
pub struct PyNotImplemented;
Expand Down