Repository navigation
Fix nightly clippy warnings - #3817
Merged
Merged
Conversation
Contributor
|
We can fix these, but I need to remind myself to switch Clippy to the stable channel next Thursday (when Rust 1.62 is released). Regarding that failure in test_strtod, I think the offending test should be just outright skipped. |
fanninpm
reviewed
Jun 23, 2022
| @unittest.skipIf(sys.platform == "win32", "TODO: RUSTPYTHON, possibly flaky test on Windows?") | ||
| # TODO: RUSTPYTHON, Incorrectly rounded str->float conversion for -07e-321 | ||
| @unittest.expectedFailure | ||
| @unittest.skip("TODO: RUSTPYTHON, possibly flaky test on Windows?") |
Contributor
There was a problem hiding this comment.
It's not just on Windows. (I wonder if it's related to why test_halfway_cases is flaky…)
Suggested change
| @unittest.skip("TODO: RUSTPYTHON, possibly flaky test on Windows?") | |
| @unittest.skip("TODO: RUSTPYTHON, possibly flaky test?") |
Member
Author
|
@fanninpm I didn't fix beta warnings. I used nightly clippy. |
This was referenced Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.