Repository navigation
Fix dict.fromkeys to return correct type - #3585
Merged
Merged
Conversation
fanninpm
reviewed
Mar 28, 2022
Contributor
Author
|
Now |
dieterplex
force-pushed
the
fixtestuserdict
branch
from
March 29, 2022 02:26
21485a0 to
322468b
Compare
youknowone
reviewed
Mar 29, 2022
dieterplex
force-pushed
the
fixtestuserdict
branch
2 times, most recently
from
March 29, 2022 15:30
db9dd9b to
1b7a3fe
Compare
dieterplex
marked this pull request as ready for review
March 29, 2022 16:08
Contributor
|
@youknowone Windows failure is because Chocolatey couldn't download openssl. Can we rerun just that job? |
Based on CPython implementation, dictobject.c, construct the new object with type and call corresponding setitem method.
dieterplex
force-pushed
the
fixtestuserdict
branch
from
March 30, 2022 01:26
1b7a3fe to
3037508
Compare
Contributor
Author
|
Update commit message to trigger rerun. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.