Skip to content

Ignore CPython specific testing/template modules. - #3250

Merged
youknowone merged 2 commits into
RustPython:mainfrom
DimitrisJim:ignore_cpy_specifics
Oct 8, 2021
Merged

Ignore CPython specific testing/template modules. #3250
youknowone merged 2 commits into
RustPython:mainfrom
DimitrisJim:ignore_cpy_specifics

Conversation

@DimitrisJim

@DimitrisJim DimitrisJim commented Oct 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

which aren't directly applicable for RustPython. (I've added [skip ci], since this isn't tested anywhere and a run would be pointless)

@DimitrisJim

DimitrisJim commented Oct 7, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Also moved where not_impl.py is written from snippets/ into extra_tests/. snippets contains many *.py files that can easily conflict with a module name (specifically, numbers.py was conflicting in this case and causing errors for fractions, _pydecimal, statistics and one other I forget, meaning they get reported as non-existant).

Moving it up one level saves us from worrying too much about it.

@jamestwebber jamestwebber mentioned this pull request Oct 8, 2021
Closed
@youknowone
youknowone merged commit bff6393 into RustPython:main Oct 8, 2021
@DimitrisJim
DimitrisJim deleted the ignore_cpy_specifics branch November 7, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DimitrisJim @youknowone