Repository navigation
suggestion: corelib only expose pymodules - #3165
Closed
youknowone wants to merge 1 commit into
Closed
youknowone wants to merge 1 commit into
youknowone wants to merge 1 commit into
Conversation
youknowone
marked this pull request as draft
September 28, 2021 18:36
youknowone
force-pushed
the
corelib-pymodule
branch
from
September 28, 2021 18:41
09b9cda to
f2b8699
Compare
Member
|
An alternative is I guess to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sugestion about module public api.
What users should see in our module public api?
My suggestion is the same as Python.
So, if there is
time.time()in Python,corelib::time::time()in Rust.To achieve this, we need to expose inner pymodule to public api, not the outer one currently in
vm::stdlib