Skip to content

Implement Mapping Protocol #3121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 14 commits into from
Oct 2, 2021
Merged

Implement Mapping Protocol #3121

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
14ce6aa
add slot_as_mapping slots with atomic cell
Snowapril Sep 20, 2021
77351b3
add PyMapping struct for mapping protocol
Snowapril Sep 20, 2021
1b6cdf5
rename length to compute_length
Snowapril Sep 20, 2021
fc761b4
add mapping protocol to proper types
Snowapril Sep 20, 2021
e83b68b
apply mapping protocol in itemprotocol
Snowapril Sep 20, 2021
b197a17
switch RangeIndex to PyObjectRef
Snowapril Sep 22, 2021
4f009ef
switch SequenceIndex to PyObjectRef
Snowapril Sep 22, 2021
1fbbdaa
support delitem in ass_subscript
Snowapril Sep 22, 2021
6e11b89
add mapping protocol methods to update_slot
Snowapril Sep 29, 2021
9e5120d
add mapping type check to mappingproxy
Snowapril Sep 29, 2021
4fd0681
move mapping protocol to rustpython_vm::protocol
Snowapril Sep 29, 2021
aa2a7f0
add PyMapping as PyObjectRef wrapper
Snowapril Sep 30, 2021
a81b3f9
fix posix & winapi to use proper PyMapping
Snowapril Oct 2, 2021
7b0965c
turn unreachable function to cold
youknowone Oct 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
apply mapping protocol in itemprotocol
  • Loading branch information
@Snowapril
Snowapril committed Oct 2, 2021
commit e83b68b810d66ce4837cc3fbb1e3b06e1abb709d
13 changes: 13 additions & 0 deletions vm/src/pyobject.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ use crate::{
builtinfunc::PyNativeFuncDef,
bytearray, bytes,
code::{self, PyCode},
dict::PyMapping,
getset::{IntoPyGetterFunc, IntoPySetterFunc, PyGetSet},
namespace::PyNamespace,
object, pystr,
Expand Down Expand Up @@ -639,6 +640,12 @@ where
T: IntoPyObject,
{
fn get_item(&self, key: T, vm: &VirtualMachine) -> PyResult {
if let Ok(map) = PyMapping::try_from_borrowed_object(vm, self) {
if let Some(getitem) = map.subscript {
return getitem(self.clone(), key.into_pyobject(vm), vm);
}
}

@youknowone youknowone Oct 2, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need __getitem__ call under this line? I think PyMapping covers the whole cases

@Snowapril Snowapril Oct 2, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. there exists extra steps (sequence protocol check & method lookup) as cpython implementation

match vm.get_special_method(self.clone(), "__getitem__")? {
Ok(special_method) => return special_method.invoke((key,), vm),
Err(obj) => {
Expand All @@ -656,6 +663,12 @@ where
}

fn set_item(&self, key: T, value: PyObjectRef, vm: &VirtualMachine) -> PyResult<()> {
if let Ok(map) = PyMapping::try_from_borrowed_object(vm, self) {
if let Some(setitem) = map.ass_subscript {
return setitem(self.clone(), key.into_pyobject(vm), value, vm);
}
}

vm.get_special_method(self.clone(), "__setitem__")?
.map_err(|obj| {
vm.new_type_error(format!(
Expand Down