Skip to content

All exceptions are now modified with extend_exception! macro #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 14 commits into from
Sep 15, 2021
Merged

All exceptions are now modified with extend_exception! macro #2974

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ab09e7c
All exceptions are now modified with `extend_Exception!` macro
sobolevn Aug 26, 2021
9f34b4a
No extra `,` allowed
sobolevn Aug 26, 2021
943d9d4
Experiments
sobolevn Aug 28, 2021
81e3fd1
Uses `define_exception!` macro
sobolevn Aug 28, 2021
8030b59
Fixes CI
sobolevn Aug 28, 2021
eaba23c
Fixes typo
sobolevn Aug 28, 2021
c5eb0bd
Adds `init` as a macro parameter
sobolevn Aug 28, 2021
a69a866
Fixes CI
sobolevn Aug 28, 2021
f8d5fc8
Fixes CI
sobolevn Aug 28, 2021
77e6591
Fixes CI
sobolevn Aug 28, 2021
a167b06
Fixes CI
sobolevn Aug 29, 2021
bc48ca6
Fixes CI
sobolevn Aug 29, 2021
8622e3c
My wild guess
sobolevn Aug 29, 2021
63db6d7
rebased code
sobolevn Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes CI
  • Loading branch information
@sobolevn
sobolevn committed Sep 15, 2021
commit bc48ca6dee5b487264dfdee86eb10794541504dc
7 changes: 0 additions & 7 deletions extra_tests/snippets/builtin_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import builtins
import platform
import sys
import os


# Regression to:
Expand Down Expand Up @@ -189,12 +188,6 @@ class SubError(MyError):
assert OSError.strerror
assert OSError(1, 2).errno
assert OSError(1, 2).strerror
if os.name == 'nt':
assert OSError.winerror
assert OSError(1, 2).winerror
else:
assert getattr(OSError, 'winerror', None) is None
assert getattr(OSError(1, 2), 'winerror', None) is None

# Custom `__new__` and `__init__`:
assert ImportError.__init__.__qualname__ == 'ImportError.__init__'
Expand Down