SaturatedSliceIter::next has overflow bug #3468

Activity

1. Snowapril commented on Nov 28, 2021

   

   Snowapril

   on Nov 28, 2021

   Contributor

   More actions

   cargo run Lib/test/test_userlist.py -v -k test_extendedslicing 

   above one also panicked by same reasom
2. Snowapril commented on Nov 28, 2021

   

   Snowapril

   on Nov 28, 2021

   Contributor

   More actions

   a = self.type2test(range(10))
   del a[9::1<<333]

   These line make panicked
3. Snowapril commented on Nov 28, 2021

   

   Snowapril

   on Nov 28, 2021

   Last edited by Snowapril

   Contributor

   More actions

   SaturatedSliceIter used for both set_slice and del_slice, but del_slice seems required different condition for iterating.
   set_slice(subscript in cpython) loop with condition on slice length, but del_slice(ass_subscript in cpython) check current index is over stop or not.

   👍React with 👍1Reacted by Steve Shi
4. qingshi163

   added a commit that references this issue on Nov 28, 2021

   fix RustPython#3468 SaturatedSliceIter overflow

   This issue will close once commit 296afbc is merged into the 'master' branch.

   296afbc
5. youknowone

   closed this as completedin #3472on Nov 28, 2021
6. youknowone

   added a commit that references this issue on Nov 28, 2021

   Merge pull request #3472 from qingshi163/fix-slice-overflow

   ...

   This issue will close once commit e740de6 is merged into the 'main' branch.

   e740de6