fixed indentation in AST pretty printed expanded dump of trait. - #1810

@00AR this is the output I get when running your commit on the testcase in #1785:

#[lang = "clone"]
trait Copy{
		fn clone(&self) -> Self;

		fn clone_from(& mut self, source: &Self)
}

there's still one extra indentation level.

I think the changes you need to make are within the Trait visitor, so Dump::visit(Trait &trait). There is probably an extra indentation.increment() somewhere. Hope it's not too annoying to fix haha :D

Let me know if you'd like any tips or if anything in the code is unclear.

It was strange at first because it gave correct output on my system. But I may have undid this second change(Sorry!) because the lines looks exactly the same without building gccrs freshly 😅
This is the output now : -

Let me know if you'd like any tips or if anything in the code is unclear.

@CohenArthur Thanks! I will surely ask on Zulip :)

@00AR here's a simpler testcase which should help you:

trait Foo {
    fn a();
    fn b(&self);
}

impl Foo for i32 {
    fn a() {}
    fn b(&self) {}
}

On master branch, the output is as follows:

trait Foo{
		fn a() ;

		fn b(&self) ;

}

impl Foo for i32 {
	fn a() {
	}

		fn b(&self) {
	}


}

with this PR:

trait Foo{
		fn a() ;

	fn b(&self) ;

}

impl Foo for i32 {
	fn a() {
	}

	fn b(&self) {
	}


}

so you fixed almost all of the issues :) thank you

I am learning rust in parallel to make new relevant testcases for the future changes I will make.
Also, this Changelog check, is it relevant for this PR?

I am learning rust in parallel to make new relevant testcases for the future changes I will make.

Nice :D Thanks for getting into this :)

Also, this Changelog check, is it relevant for this PR?

Yes, moving forward all commits will need to conform to the GNU guidelines. We're putting together automation to make the process less painful.

@00AR if you're done with this PR let me know and I'll post the Changelog content here for you to add to your commit. Then, we can merge this.

@CohenArthur Thanks. I will ping you once I finish testing some other parts that I suspect may also need some correction.

@CohenArthur You can merge this PR when you get time.
My eyes couldn't find any more indentations to remove but this PR has helped me in getting started with HIR dump project ;-)
I was able to add a small change to HIR dump comfortably. I will focus on making a GSOC proposal for the same. I also have some questions now :D

Great stuff @00AR thank you! The one thing remaining for you is to add a Changelog to your commit according to the following structure:

gcc/rust/ChangeLog:

	* ast/rust-ast-dump.cc (Dump::visit):

Also, feel free to ping me on Zulip and ask your questions :)

The Changelog needs to sit above the Signed-off-by line. Then we can merge this PR :)

bors r+

Build succeeded:

• build-and-check-gcc-48
• build-and-check-ubuntu-32bit
• build-and-check-ubuntu-64bit