Skip to content

Add a python equivalent to MATLABs smoothdata and use in Bayes plots #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikeSullivan7 merged 5 commits into from
Jun 16, 2026
+93 −8
Merged

Add a python equivalent to MATLABs smoothdata and use in Bayes plots #208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3525c7b
Add a python equivalent to MATLABs smoothdata and use in Bayes plots
MikeSullivan7 May 19, 2026
64e8bd7
suggested changes to moving_average
MikeSullivan7 May 22, 2026
cb07370
unit test test_moving_average
MikeSullivan7 Jun 1, 2026
e2084c0
ruff fix
MikeSullivan7 Jun 1, 2026
3b6a7c4
use ValueError if moving_average window size is out of bounds
MikeSullivan7 Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
use ValueError if moving_average window size is out of bounds
  • Loading branch information
@MikeSullivan7
MikeSullivan7 committed Jun 16, 2026
commit 3b6a7c4d494c182d78ac9e667411827d6af0e70d
8 changes: 5 additions & 3 deletions ratapi/utils/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,7 +1132,6 @@ def validate_dens_type(dens_type: str | None, param: str):
results,
i,
smooth=smooth,
sigma=sigma,
estimated_density=estimated_density.get(i),
axes=ax,
**hist_settings,
Expand Down Expand Up @@ -1247,14 +1246,17 @@ def moving_average(data: np.ndarray, window_size: int = 8) -> list[float]:
computing an average over the elements within each window.

"""
assert 0 <= window_size <= len(data)
if not 0 <= window_size <= len(data):
raise ValueError(
"The moving average window size is out of range. Please change to a positive integer which "
"does not exceed the number of histogram bins."
)
moving_averages = []

for i in range(len(data)):
start_window_ind = floor(float(i - window_size / 2)) if i - window_size / 2 > 0 else 0
end_window_ind = floor(float(i + window_size / 2)) if i + window_size / 2 < len(data) else len(data)
window_average = np.sum(data[start_window_ind:end_window_ind]) / (end_window_ind + 0 - start_window_ind)
moving_averages.append(window_average)
i += 1

return moving_averages
4 changes: 2 additions & 2 deletions tests/test_plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,8 +548,8 @@ def test_moving_average() -> None:
18.5,
]

with pytest.raises(AssertionError):
with pytest.raises(ValueError):
RATplot.moving_average(data_to_average, window_size=-1)

with pytest.raises(AssertionError):
with pytest.raises(ValueError):
RATplot.moving_average(data_to_average, window_size=len(data_to_average) + 1)
Loading