Skip to content

Refactor/optimize binary operations #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tahgolov wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Refactor/optimize binary operations #90

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
427bc41
optimize package id decoding
Tahgolov Aug 14, 2025
ce211f1
optimize range check
Tahgolov Aug 14, 2025
b21522f
optimize putBit
Tahgolov Aug 14, 2025
c20dd11
use shifting instead
Tahgolov Aug 14, 2025
5870899
optimize ValueType checks
Tahgolov Aug 14, 2025
037d71a
optimize updateSize
Tahgolov Aug 14, 2025
58294b9
use distributivity
Tahgolov Aug 14, 2025
79bd5a1
optimize
Tahgolov Aug 14, 2025
dce3033
use shifting instead of long constant
Tahgolov Aug 14, 2025
2070955
use shifting instead of long constant
Tahgolov Aug 14, 2025
2bedb1a
use unsigned shifting
Tahgolov Aug 14, 2025
7bf42b3
optimize
Tahgolov Aug 14, 2025
19b9d11
optimize
Tahgolov Aug 15, 2025
6183ee5
add unit tests for ValueType checks
Tahgolov Aug 16, 2025
6714f79
add unit tests for AttributeType checks
Tahgolov Aug 16, 2025
dcd4273
fix offset calculation and add unit test for setOffset
Tahgolov Aug 16, 2025
970d509
Merge branch 'REAndroid:main' into refactor/low-level-operatoins
Tahgolov Aug 16, 2025
121ae6a
add all value types decoding ignoring ANY
Tahgolov Aug 16, 2025
4a5ec24
fix isPackageId and isResourceId
Tahgolov Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimize
  • Loading branch information
@Tahgolov
Tahgolov committed Aug 15, 2025
commit 19b9d118949216a4da48820ca38edde2c1be6d59
4 changes: 2 additions & 2 deletions src/main/java/com/reandroid/arsc/base/Block.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public static void putInteger(byte[] bytes, int offset, int val){
if((offset + 4) > bytes.length){
return;
}
bytes[offset + 3]= (byte) (val >>> 24 & 0xff);
bytes[offset + 3]= (byte) (val >>> 24);
bytes[offset + 2]= (byte) (val >>> 16 & 0xff);
bytes[offset + 1]= (byte) (val >>> 8 & 0xff);
bytes[offset]= (byte) (val & 0xff);
Expand Down Expand Up @@ -240,7 +240,7 @@ public static void putBigEndianInteger(byte[] bytes, int offset, int value) {
if((offset + 4) > bytes.length) {
return;
}
bytes[offset]= (byte) (value >>> 24 & 0xff);
bytes[offset]= (byte) (value >>> 24);
bytes[offset + 1]= (byte) (value >>> 16 & 0xff);
bytes[offset + 2]= (byte) (value >>> 8 & 0xff);
bytes[offset + 3]= (byte) (value & 0xff);
Expand Down