Skip to content

optimize resource table build #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rotundtapir wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −16
Open

optimize resource table build #104

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46eead2
Update block indexes once after sorting instead of on every swap
rotundtapir Aug 27, 2026
c70337a
Skip sorting a block list that is already in order
rotundtapir Aug 27, 2026
8b20a7f
Drop the per-package refresh while encoding values
rotundtapir Aug 27, 2026
8572381
Look up defined entries by resolved id instead of scanning references
rotundtapir Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update block indexes once after sorting instead of on every swap 
BlockList.sort() registered a swap listener that called setIndex() on both
items of every quicksort swap. For items that maintain back references, such
as StringItem, each setIndex() triggers onIndexChanged() which rewrites every
reference to the item, so a single sort of a large string pool performed
O(swaps x references) work while all intermediate index values were
immediately overwritten. The updateIndex() pass that already runs after the
sort assigns each item its final index exactly once, firing onIndexChanged()
a single time per moved item, so the per-swap updates are redundant.

Sorting a resource table string pool of a large apk gets several times
faster; the resulting order and all reference values are unchanged.
  • Loading branch information
@rotundtapir
rotundtapir committed Aug 28, 2026
commit 46eead20284b13318bfb4ae6b347414715b20338
11 changes: 1 addition & 10 deletions src/main/java/com/reandroid/arsc/container/BlockList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,16 +201,7 @@ public boolean sort(Comparator<? super T> comparator) {
if (size() < 2) {
return false;
}
boolean sorted = mItems.sort(comparator, (i, j) -> {
T item1 = get(i);
T item2 = get(j);
if (item1 != null) {
item1.setIndex(i);
}
if (item2 != null) {
item2.setIndex(j);
}
});
boolean sorted = mItems.sortItems(comparator);
if (sorted) {
updateIndex();
}
Expand Down