Repository navigation
FOUR-32246 Ethos user sync failure caused by insufficient lastname field length - #9096
Open
devmiguelangel wants to merge 4 commits into
Open
devmiguelangel wants to merge 4 commits into
devmiguelangel wants to merge 4 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Issue & Reproduction Steps
Ethos user sync fails when a person's first or last name exceeds 50 characters (
SQLSTATE[22001]: Data too long for column 'lastname'). Example:Mohamed Abdelmoneim Ramadan Mohamed Abdallah Elrefai(51 characters).users.Solution
users.firstnameandusers.lastnamefromVARCHAR(50)toVARCHAR(255)(down()is intentionally empty).max:50tomax:255inUser::rules()and in installer admin name prompts.How to Test
php artisan migrateand confirmSHOW COLUMNS FROM usersshowsvarchar(255)forfirstnameandlastname.tests/Feature/Api/UsersTest.phpmethodstestCreateUserAcceptsNamesUpTo255CharactersandtestCreateUserRejectsLastnameLongerThan255Characters.Related Tickets & Packages
FOUR-32246
https://github.com/ProcessMaker/package-ellucian-ethos/pull/145
Code Review Checklist
ci:package-ellucian-ethos:FOUR-32246