Skip to content

Fix retries and run microservice requests synchronously #7949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boliviacoca merged 4 commits into from
Jan 28, 2025
Merged

Fix retries and run microservice requests synchronously #7949

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d13d022
Fix retries for sync requests
nolanpro Jan 22, 2025
dcb1cc0
Make script tasks run synchronously
nolanpro Jan 22, 2025
cba3d43
Always update data
nolanpro Jan 28, 2025
007e383
Fix query condition parenthesis (causing test failure)
nolanpro Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Always update data
  • Loading branch information
@nolanpro
nolanpro committed Jan 28, 2025
commit cba3d436238b2ed854f9faee39a7133b73fdb101
5 changes: 1 addition & 4 deletions ProcessMaker/Jobs/RunScriptTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,7 @@ public function action(ProcessRequestToken $token = null, ScriptTaskInterface $e
];
$response = $script->runScript($data, $configuration, $token->getId(), $errorHandling->timeout(), 1, $metadata);

if (!config('script-runner-microservice.enabled') ||
($scriptExecutor && $scriptExecutor->type === ScriptExecutorType::Custom)) {
$this->updateData($response);
}
$this->updateData($response);
} catch (ConfigurationException $exception) {
$this->unlock();
$this->updateData(['output' => $exception->getMessageForData($token)]);
Expand Down